Re: [PATCH v2 4/9] xen/arm: do not relocate Xen outside of visible RAM

[Julien Grall <julien.grall@linaro.org>]

On 09/13/2013 12:40 PM, Ian Campbell wrote:
> Since we do not handle non-contiguous banks of memory lets avoid relocatting
s/relocatting/relocating/
> Xen into such a bank. Avoids issues such as free_init_memory releasing pages
> which are outside of the frametable.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  xen/arch/arm/setup.c |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index ab3d9aa..8d8028c 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -240,17 +240,24 @@ static paddr_t __init get_xen_paddr(void)
>  {
>      struct dt_mem_info *mi = &early_info.mem;
>      paddr_t min_size;
> -    paddr_t paddr = 0;
> +    paddr_t paddr = 0, last_end;
>      int i;
>  
>      min_size = (_end - _start + (XEN_PADDR_ALIGN-1)) & ~(XEN_PADDR_ALIGN-1);
>  
> +    last_end = mi->bank[0].start;
> +
>      /* Find the highest bank with enough space. */
>      for ( i = 0; i < mi->nr_banks; i++ )
>      {
>          const struct membank *bank = &mi->bank[i];
>          paddr_t s, e;
>  
> +        if ( last_end != bank->start )
> +            break;
> +

Can you add a comment in the code to specify that we are relocating Xen
in a "contiguous bank"?

> +        last_end = bank->start + bank->size;
> +
>          if ( bank->size >= min_size )
>          {
>              e = consider_modules(bank->start, bank->start + bank->size,
> 

-- 
Julien Grall