Re: [PATCH v2 5/9] xen/arm: cope with modules outside of "visible" RAM

[Julien Grall <julien.grall@linaro.org>]

On 09/13/2013 12:40 PM, Ian Campbell wrote:
> This can happen if modules are in a bank which we can't cope with e.g. due to
> being non-contiguous.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  xen/arch/arm/setup.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 8d8028c..0d9eaf7 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -387,6 +387,12 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size)
>              e = n = ram_end;
>          }
>  
> +        /* Module in RAM which we cannot see here, due to not handling
> +         * non-contiguous memory regions yes
s/yes/yet.

Except this minor typo:

Reviewed-by: Julien Grall <julien.grall@linaro.org>

> +         */
> +        if ( e > ram_end )
> +            e = ram_end;
> +
>          /* Avoid the xenheap */
>          if ( s < ((xenheap_mfn_start+xenheap_pages) << PAGE_SHIFT)
>               && (xenheap_mfn_start << PAGE_SHIFT) < e )
> 


-- 
Julien Grall