From: Stephen Warren <swarren@wwwdotorg.org>
To: Bill Huang <bilhuang@nvidia.com>
Cc: rjw@sisk.pl, viresh.kumar@linaro.org, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 3/4] cpufreq: tegra: Re-model Tegra cpufreq driver
Date: Fri, 13 Sep 2013 16:26:14 -0600 [thread overview]
Message-ID: <52339106.4020601@wwwdotorg.org> (raw)
In-Reply-To: <1378985091-9447-4-git-send-email-bilhuang@nvidia.com>
On 09/12/2013 05:24 AM, Bill Huang wrote:
> Re-model Tegra cpufreq driver to support all Tegra series of SoCs.
>
> * Make tegra-cpufreq.c a generic Tegra cpufreq driver.
> * Move Tegra20 specific codes into tegra20-cpufreq.c.
> * Bind Tegra cpufreq dirver with a fake device so defer probe would work
> when we're going to get regulator in the driver to support voltage
> scaling (DVFS).
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> @@ -232,6 +232,12 @@ config ARM_TEGRA_CPUFREQ
> bool "TEGRA CPUFreq support"
> depends on ARCH_TEGRA
> select CPU_FREQ_TABLE
> +
> +config ARM_TEGRA20_CPUFREQ
> + bool "NVIDIA TEGRA20"
> + depends on ARM_TEGRA_CPUFREQ && ARCH_TEGRA_2x_SOC
> default y
> help
> - This adds the CPUFreq driver support for TEGRA SOCs.
> + This adds the CPUFreq driver for NVIDIA TEGRA20 SoC.
> +
> + If in doubt, say N.
This patch removes the following from "config ARM_TEGRA_CPUFREQ":
default y
help
This adds the CPUFreq driver support for TEGRA SOCs.
I think that option should be left unchanged, such that this patch
*just* adds the new option without changing the existing one. If you do
that, then you can completely drop patch 4/4.
Other than that, this series looks fine.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] cpufreq: tegra: Re-model Tegra cpufreq driver
Date: Fri, 13 Sep 2013 16:26:14 -0600 [thread overview]
Message-ID: <52339106.4020601@wwwdotorg.org> (raw)
In-Reply-To: <1378985091-9447-4-git-send-email-bilhuang@nvidia.com>
On 09/12/2013 05:24 AM, Bill Huang wrote:
> Re-model Tegra cpufreq driver to support all Tegra series of SoCs.
>
> * Make tegra-cpufreq.c a generic Tegra cpufreq driver.
> * Move Tegra20 specific codes into tegra20-cpufreq.c.
> * Bind Tegra cpufreq dirver with a fake device so defer probe would work
> when we're going to get regulator in the driver to support voltage
> scaling (DVFS).
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> @@ -232,6 +232,12 @@ config ARM_TEGRA_CPUFREQ
> bool "TEGRA CPUFreq support"
> depends on ARCH_TEGRA
> select CPU_FREQ_TABLE
> +
> +config ARM_TEGRA20_CPUFREQ
> + bool "NVIDIA TEGRA20"
> + depends on ARM_TEGRA_CPUFREQ && ARCH_TEGRA_2x_SOC
> default y
> help
> - This adds the CPUFreq driver support for TEGRA SOCs.
> + This adds the CPUFreq driver for NVIDIA TEGRA20 SoC.
> +
> + If in doubt, say N.
This patch removes the following from "config ARM_TEGRA_CPUFREQ":
default y
help
This adds the CPUFreq driver support for TEGRA SOCs.
I think that option should be left unchanged, such that this patch
*just* adds the new option without changing the existing one. If you do
that, then you can completely drop patch 4/4.
Other than that, this series looks fine.
next prev parent reply other threads:[~2013-09-13 22:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 11:24 [PATCH v2 0/4] Remodel Tegra cpufreq driver to support Tegra series SoCs Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` [PATCH v2 1/4] cpufreq: tegra: Call tegra_cpufreq_init() specifically in machine code Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` [PATCH v2 2/4] cpufreq: tegra: Remove not used header files and clean up codes Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` [PATCH v2 3/4] cpufreq: tegra: Re-model Tegra cpufreq driver Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-13 22:26 ` Stephen Warren [this message]
2013-09-13 22:26 ` Stephen Warren
2013-09-14 2:00 ` Bill Huang
2013-09-14 2:00 ` Bill Huang
2013-09-12 11:24 ` [PATCH v2 4/4] ARM: tegra: defconfig updates Bill Huang
2013-09-12 11:24 ` Bill Huang
2013-09-12 11:24 ` Bill Huang
[not found] ` <1378985091-9447-1-git-send-email-bilhuang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-12 11:27 ` [PATCH v2 0/4] Remodel Tegra cpufreq driver to support Tegra series SoCs Viresh Kumar
2013-09-12 11:27 ` Viresh Kumar
2013-09-12 11:27 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52339106.4020601@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bilhuang@nvidia.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.