From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-iio@vger.kernel.org, Barry Song <21cnbao@gmail.com>
Subject: Re: [PATCH 1/1] staging: iio: ade7854-spi: Fix return value
Date: Sat, 14 Sep 2013 11:28:03 +0100 [thread overview]
Message-ID: <52343A33.9090703@kernel.org> (raw)
In-Reply-To: <1378891978-3819-1-git-send-email-sachin.kamat@linaro.org>
On 09/11/13 10:32, Sachin Kamat wrote:
> ade7854_probe can fail. Return the value obtained from it
> instead of 0 (success).
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Barry Song <21cnbao@gmail.com>
Applied to the the fixes-togreg branch of iio.git
Thanks
> ---
> drivers/staging/iio/meter/ade7854-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
> index a802cf2..4c6d204 100644
> --- a/drivers/staging/iio/meter/ade7854-spi.c
> +++ b/drivers/staging/iio/meter/ade7854-spi.c
> @@ -299,7 +299,7 @@ static int ade7854_spi_probe(struct spi_device *spi)
> if (ret)
> iio_device_free(indio_dev);
>
> - return 0;
> + return ret;
> }
>
> static int ade7854_spi_remove(struct spi_device *spi)
>
prev parent reply other threads:[~2013-09-14 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 9:32 [PATCH 1/1] staging: iio: ade7854-spi: Fix return value Sachin Kamat
2013-09-14 10:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52343A33.9090703@kernel.org \
--to=jic23@kernel.org \
--cc=21cnbao@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.