* [PATCH 1/1] staging: iio: ade7854-spi: Fix return value
@ 2013-09-11 9:32 Sachin Kamat
2013-09-14 10:28 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-09-11 9:32 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, sachin.kamat, Barry Song
ade7854_probe can fail. Return the value obtained from it
instead of 0 (success).
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Barry Song <21cnbao@gmail.com>
---
drivers/staging/iio/meter/ade7854-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
index a802cf2..4c6d204 100644
--- a/drivers/staging/iio/meter/ade7854-spi.c
+++ b/drivers/staging/iio/meter/ade7854-spi.c
@@ -299,7 +299,7 @@ static int ade7854_spi_probe(struct spi_device *spi)
if (ret)
iio_device_free(indio_dev);
- return 0;
+ return ret;
}
static int ade7854_spi_remove(struct spi_device *spi)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] staging: iio: ade7854-spi: Fix return value
2013-09-11 9:32 [PATCH 1/1] staging: iio: ade7854-spi: Fix return value Sachin Kamat
@ 2013-09-14 10:28 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2013-09-14 10:28 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-iio, Barry Song
On 09/11/13 10:32, Sachin Kamat wrote:
> ade7854_probe can fail. Return the value obtained from it
> instead of 0 (success).
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Barry Song <21cnbao@gmail.com>
Applied to the the fixes-togreg branch of iio.git
Thanks
> ---
> drivers/staging/iio/meter/ade7854-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
> index a802cf2..4c6d204 100644
> --- a/drivers/staging/iio/meter/ade7854-spi.c
> +++ b/drivers/staging/iio/meter/ade7854-spi.c
> @@ -299,7 +299,7 @@ static int ade7854_spi_probe(struct spi_device *spi)
> if (ret)
> iio_device_free(indio_dev);
>
> - return 0;
> + return ret;
> }
>
> static int ade7854_spi_remove(struct spi_device *spi)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-14 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 9:32 [PATCH 1/1] staging: iio: ade7854-spi: Fix return value Sachin Kamat
2013-09-14 10:28 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.