All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] configure: Enable extra compiler warnings
Date: Sat, 14 Sep 2013 21:38:29 +0400	[thread overview]
Message-ID: <52349F15.3020706@msgid.tls.msk.ru> (raw)
In-Reply-To: <5234812D.8080905@weilnetz.de>

14.09.2013 19:30, Stefan Weil wrote:
> Am 14.09.2013 14:18, schrieb Michael Tokarev:
[]
>> Well.  I see at least one hidden flag here which is not covered by the
>> description:
>>
>> -gcc_flags="-Wendif-labels $gcc_flags"
>> +gcc_flags="-fstack-protector-all -Wendif-labels $gcc_flags"
>>
>> Is it intentional?
>
> No, -fstack-protector-all should not be there. It might be a relict of
> a previous patch rebase: I added -Wextra in my local branch a long
> time ago, and -fstack-protector-all was obviously moved to another
> location in configure during that time.
>
> I can send an updated patch later, or you can just remove it from
> my original patch.

Please take a look at the resulting patch at
  http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
and see if this is the patch you want to be applied.

I verified it compiles on FreeBSD 9.1, but I tried only minimal set
of optional dependencies so things might still break, but I think
we can fix it later.

If it looks okay, I'll send a pull request today.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Enable extra compiler warnings
Date: Sat, 14 Sep 2013 21:38:29 +0400	[thread overview]
Message-ID: <52349F15.3020706@msgid.tls.msk.ru> (raw)
In-Reply-To: <5234812D.8080905@weilnetz.de>

14.09.2013 19:30, Stefan Weil wrote:
> Am 14.09.2013 14:18, schrieb Michael Tokarev:
[]
>> Well.  I see at least one hidden flag here which is not covered by the
>> description:
>>
>> -gcc_flags="-Wendif-labels $gcc_flags"
>> +gcc_flags="-fstack-protector-all -Wendif-labels $gcc_flags"
>>
>> Is it intentional?
>
> No, -fstack-protector-all should not be there. It might be a relict of
> a previous patch rebase: I added -Wextra in my local branch a long
> time ago, and -fstack-protector-all was obviously moved to another
> location in configure during that time.
>
> I can send an updated patch later, or you can just remove it from
> my original patch.

Please take a look at the resulting patch at
  http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next
and see if this is the patch you want to be applied.

I verified it compiles on FreeBSD 9.1, but I tried only minimal set
of optional dependencies so things might still break, but I think
we can fix it later.

If it looks okay, I'll send a pull request today.

Thanks,

/mjt

  reply	other threads:[~2013-09-14 17:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  5:44 [Qemu-devel] [PATCH] configure: Enable extra compiler warnings Stefan Weil
2013-09-03 18:28 ` [Qemu-trivial] " Stefan Weil
2013-09-03 18:28   ` [Qemu-devel] " Stefan Weil
2013-09-14 12:18   ` [Qemu-trivial] " Michael Tokarev
2013-09-14 12:18     ` [Qemu-devel] " Michael Tokarev
2013-09-14 15:30     ` Stefan Weil
2013-09-14 15:30       ` [Qemu-devel] " Stefan Weil
2013-09-14 17:38       ` Michael Tokarev [this message]
2013-09-14 17:38         ` Michael Tokarev
2013-09-14 17:46         ` Stefan Weil
2013-09-14 17:46           ` [Qemu-devel] " Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52349F15.3020706@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.