From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Eddie Dong <eddie.dong@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH 1/2] VMX: also use proper instruction mnemonic for VMREAD
Date: Mon, 16 Sep 2013 12:53:20 +0100 [thread overview]
Message-ID: <5236F130.8050701@citrix.com> (raw)
In-Reply-To: <5237024902000078000F3962@nat28.tlf.novell.com>
On 16/09/2013 12:06, Jan Beulich wrote:
> vmx_vmcs_enter(v);
>
> switch ( seg )
> {
> case x86_seg_cs:
> - reg->sel = __vmread(GUEST_CS_SELECTOR);
> - reg->limit = __vmread(GUEST_CS_LIMIT);
> - reg->base = __vmread(GUEST_CS_BASE);
> - attr = __vmread(GUEST_CS_AR_BYTES);
> + __vmread(GUEST_CS_SELECTOR, &sel);
> + __vmread(GUEST_CS_LIMIT, &limit);
> + __vmread(GUEST_CS_BASE, ®->base);
> + __vmread(GUEST_CS_AR_BYTES, &attr);
> break;
> case x86_seg_ds:
> - reg->sel = __vmread(GUEST_DS_SELECTOR);
> - reg->limit = __vmread(GUEST_DS_LIMIT);
> - reg->base = __vmread(GUEST_DS_BASE);
> - attr = __vmread(GUEST_DS_AR_BYTES);
> + __vmread(GUEST_DS_SELECTOR, &sel);
> + __vmread(GUEST_DS_LIMIT, &limit);
> + __vmread(GUEST_DS_BASE, ®->base);
> + __vmread(GUEST_DS_AR_BYTES, &attr);
> break;
> case x86_seg_es:
> - reg->sel = __vmread(GUEST_ES_SELECTOR);
> - reg->limit = __vmread(GUEST_ES_LIMIT);
> - reg->base = __vmread(GUEST_ES_BASE);
> - attr = __vmread(GUEST_ES_AR_BYTES);
> + __vmread(GUEST_ES_SELECTOR, &sel);
> + __vmread(GUEST_ES_LIMIT, &limit);
> + __vmread(GUEST_ES_BASE, ®->base);
> + __vmread(GUEST_ES_AR_BYTES, &attr);
> break;
> case x86_seg_fs:
> - reg->sel = __vmread(GUEST_FS_SELECTOR);
> - reg->limit = __vmread(GUEST_FS_LIMIT);
> - reg->base = __vmread(GUEST_FS_BASE);
> - attr = __vmread(GUEST_FS_AR_BYTES);
> + __vmread(GUEST_FS_SELECTOR, &sel);
> + __vmread(GUEST_FS_LIMIT, &limit);
> + __vmread(GUEST_FS_BASE, ®->base);
> + __vmread(GUEST_FS_AR_BYTES, &attr);
> break;
> case x86_seg_gs:
> - reg->sel = __vmread(GUEST_GS_SELECTOR);
> - reg->limit = __vmread(GUEST_GS_LIMIT);
> - reg->base = __vmread(GUEST_GS_BASE);
> - attr = __vmread(GUEST_GS_AR_BYTES);
> + __vmread(GUEST_GS_SELECTOR, &sel);
> + __vmread(GUEST_GS_LIMIT, &limit);
> + __vmread(GUEST_GS_BASE, ®->base);
> + __vmread(GUEST_GS_AR_BYTES, &attr);
> break;
> case x86_seg_ss:
> - reg->sel = __vmread(GUEST_SS_SELECTOR);
> - reg->limit = __vmread(GUEST_SS_LIMIT);
> - reg->base = __vmread(GUEST_SS_BASE);
> - attr = __vmread(GUEST_SS_AR_BYTES);
> + __vmread(GUEST_SS_SELECTOR, &sel);
> + __vmread(GUEST_SS_LIMIT, &limit);
> + __vmread(GUEST_SS_BASE, ®->base);
> + __vmread(GUEST_SS_AR_BYTES, &attr);
> break;
> case x86_seg_tr:
> - reg->sel = __vmread(GUEST_TR_SELECTOR);
> - reg->limit = __vmread(GUEST_TR_LIMIT);
> - reg->base = __vmread(GUEST_TR_BASE);
> - attr = __vmread(GUEST_TR_AR_BYTES);
> + __vmread(GUEST_TR_SELECTOR, &sel);
> + __vmread(GUEST_TR_LIMIT, &limit);
> + __vmread(GUEST_TR_BASE, ®->base);
> + __vmread(GUEST_TR_AR_BYTES, &attr);
> break;
> case x86_seg_gdtr:
> - reg->limit = __vmread(GUEST_GDTR_LIMIT);
> - reg->base = __vmread(GUEST_GDTR_BASE);
> + __vmread(GUEST_GDTR_LIMIT, &limit);
> + __vmread(GUEST_GDTR_BASE, ®->base);
> break;
> case x86_seg_idtr:
> - reg->limit = __vmread(GUEST_IDTR_LIMIT);
> - reg->base = __vmread(GUEST_IDTR_BASE);
> + __vmread(GUEST_IDTR_LIMIT, &limit);
> + __vmread(GUEST_IDTR_BASE, ®->base);
> break;
> case x86_seg_ldtr:
> - reg->sel = __vmread(GUEST_LDTR_SELECTOR);
> - reg->limit = __vmread(GUEST_LDTR_LIMIT);
> - reg->base = __vmread(GUEST_LDTR_BASE);
> - attr = __vmread(GUEST_LDTR_AR_BYTES);
> + __vmread(GUEST_LDTR_SELECTOR, &sel);
> + __vmread(GUEST_LDTR_LIMIT, &limit);
> + __vmread(GUEST_LDTR_BASE, ®->base);
> + __vmread(GUEST_LDTR_AR_BYTES, &attr);
> break;
> default:
> BUG();
> + return;
This return is dead code.
Otherwise,
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2013-09-16 11:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 11:04 [PATCH 0/2] VMX: further code generation improvements Jan Beulich
2013-09-16 11:06 ` [PATCH 1/2] VMX: also use proper instruction mnemonic for VMREAD Jan Beulich
2013-09-16 11:53 ` Andrew Cooper [this message]
2013-09-16 12:34 ` Jan Beulich
2013-09-16 12:49 ` Andrew Cooper
2013-09-16 14:38 ` Nakajima, Jun
2013-09-16 14:43 ` Jan Beulich
2013-09-18 12:52 ` Jan Beulich
2013-09-23 7:58 ` Ping: " Jan Beulich
2013-09-23 15:17 ` Nakajima, Jun
2013-09-16 11:07 ` [PATCH 2/2] VMX: drop memory clobbers from vmread/vmwrite wrappers Jan Beulich
2013-09-16 11:54 ` Andrew Cooper
2013-09-16 14:15 ` Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5236F130.8050701@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.