From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Eddie Dong <eddie.dong@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH 2/2] VMX: drop memory clobbers from vmread/vmwrite wrappers
Date: Mon, 16 Sep 2013 12:54:50 +0100 [thread overview]
Message-ID: <5236F18A.6090609@citrix.com> (raw)
In-Reply-To: <5237028702000078000F3966@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1905 bytes --]
On 16/09/2013 12:07, Jan Beulich wrote:
> All effects are properly being described by the asm() constraints.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/include/asm-x86/hvm/vmx/vmx.h
> +++ b/xen/include/asm-x86/hvm/vmx/vmx.h
> @@ -336,12 +336,11 @@ static inline void __vmread(unsigned lon
> UNLIKELY_END_SECTION
> #ifdef HAVE_GAS_VMX
> : "=rm" (*value)
> - : "r" (field)
> + : "r" (field));
> #else
> : "=c" (*value)
> - : "a" (field)
> + : "a" (field));
> #endif
> - : "memory");
> }
>
> static inline void __vmwrite(unsigned long field, unsigned long value)
> @@ -358,11 +357,10 @@ static inline void __vmwrite(unsigned lo
> UNLIKELY_END_SECTION
> :
> #ifdef HAVE_GAS_VMX
> - : "r" (field) , "rm" (value)
> + : "r" (field) , "rm" (value));
> #else
> - : "a" (field) , "c" (value)
> + : "a" (field) , "c" (value));
> #endif
> - : "memory");
> }
>
> static inline bool_t __vmread_safe(unsigned long field, unsigned long *value)
> @@ -379,12 +377,11 @@ static inline bool_t __vmread_safe(unsig
> "setnbe %0"
> #ifdef HAVE_GAS_VMX
> : "=qm" (okay), "=rm" (*value)
> - : "r" (field)
> + : "r" (field));
> #else
> : "=qm" (okay), "=c" (*value)
> - : "a" (field)
> + : "a" (field));
> #endif
> - : "memory");
>
> return okay;
> }
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2729 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-16 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 11:04 [PATCH 0/2] VMX: further code generation improvements Jan Beulich
2013-09-16 11:06 ` [PATCH 1/2] VMX: also use proper instruction mnemonic for VMREAD Jan Beulich
2013-09-16 11:53 ` Andrew Cooper
2013-09-16 12:34 ` Jan Beulich
2013-09-16 12:49 ` Andrew Cooper
2013-09-16 14:38 ` Nakajima, Jun
2013-09-16 14:43 ` Jan Beulich
2013-09-18 12:52 ` Jan Beulich
2013-09-23 7:58 ` Ping: " Jan Beulich
2013-09-23 15:17 ` Nakajima, Jun
2013-09-16 11:07 ` [PATCH 2/2] VMX: drop memory clobbers from vmread/vmwrite wrappers Jan Beulich
2013-09-16 11:54 ` Andrew Cooper [this message]
2013-09-16 14:15 ` Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5236F18A.6090609@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.