From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] telepathy-mission-control: do_compile failed (race issue)
Date: Tue, 17 Sep 2013 10:03:34 +0800 [thread overview]
Message-ID: <5237B876.2080203@windriver.com> (raw)
In-Reply-To: <CAJTo0LZPhGjLrffo3coy_GSWLF+XhHpgyE6zTUxsPU30S72Z9Q@mail.gmail.com>
On 09/17/2013 07:49 AM, Burton, Ross wrote:
> On 17 September 2013 00:08, Burton, Ross <ross.burton@intel.com> wrote:
>>> This is a race issue, the _gen/gtypes.h and _gen/gtypes-body.h may
>>> write(remove/rename) _gen/gtypes.tmp at the same time, then there would
>>> be the error.
>>>
>>> Use ".NOTPARALLEL: _gen/gtypes.h _gen/gtypes-body.h" will fix the
>>> problem.
>>
>> This is going to be a game of whack-a-mole as the root cause is the
>> bad temporary filename assignment in libtpcodegen.py. Is there an
>> upstream bug for this?
>
> Had a quick look - there's a trivial race in the utility code that a
> bit of tempfile can fix, but the more correct fix for
> telepathy-mission-control is to do the same fix that telepathy-glib
> did here:
>
> http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=36c2a545c9c1d1cc6db205bfc33d980d29b0a0f6
I don't think that the commit you mentioned is a correct fix, he changed:
gen/gtypes.h _gen/gtypes-body.h: _gen/stable-spec.xml
To:
gen/gtypes.h: _gen/gtypes-body.h
@:
gen/gtypes-body.h: _gen/stable-spec.xml
Now if we run "make gen/gtypes.h gen/gtypes-body.h", the gen/gtypes-body.h
will only run once, this is incorrect. And this fix has been dropped in the
up to date source.
// Robert
>
> https://bugs.freedesktop.org/show_bug.cgi?id=69446 is the upstream bug
> I just filed for this.
>
> Ross
>
>
next prev parent reply other threads:[~2013-09-17 2:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 8:49 [PATCH 0/1] telepathy-mission-control: do_compile failed (race issue) Robert Yang
2013-09-14 8:49 ` [PATCH 1/1] " Robert Yang
2013-09-16 23:08 ` Burton, Ross
2013-09-16 23:49 ` Burton, Ross
2013-09-17 2:03 ` Robert Yang [this message]
2013-09-17 11:12 ` Burton, Ross
2013-09-18 2:45 ` Robert Yang
2013-09-18 6:24 ` Burton, Ross
-- strict thread matches above, loose matches on Subject: below --
2013-09-23 5:54 [PATCH 0/1 V2] " Robert Yang
2013-09-23 5:54 ` [PATCH 1/1] " Robert Yang
2013-09-23 14:07 ` Burton, Ross
2013-09-24 1:35 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5237B876.2080203@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.