From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] telepathy-mission-control: do_compile failed (race issue)
Date: Wed, 18 Sep 2013 10:45:33 +0800 [thread overview]
Message-ID: <523913CD.3080104@windriver.com> (raw)
In-Reply-To: <CAJTo0LY2DZn2WBhQMZiBe1KFHnpZwT+C6u742reGvE3GLY4LnQ@mail.gmail.com>
On 09/17/2013 07:12 PM, Burton, Ross wrote:
> On 17 September 2013 03:03, Robert Yang <liezhi.yang@windriver.com> wrote:
>> I don't think that the commit you mentioned is a correct fix, he changed:
>>
>> gen/gtypes.h _gen/gtypes-body.h: _gen/stable-spec.xml
>>
>> To:
>>
>> gen/gtypes.h: _gen/gtypes-body.h
>> @:
>> gen/gtypes-body.h: _gen/stable-spec.xml
>>
>> Now if we run "make gen/gtypes.h gen/gtypes-body.h", the gen/gtypes-body.h
>> will only run once, this is incorrect.
>
> But the Python script used in the second rule generates *both* files,
Ah, yes, thanks, what's your opinion on my patch ? Is it OK or should it be
re-worked ? I think that this fix is simple and easy to understand.
// Robert
> which is why the current rules in telepathy-mission-control are
> incorrect:
>
> ~/Local/mess/37/telepathy-mission-control/src
> $ ls _gen/gtypes*
> _gen/gtypes-body.h _gen/gtypes.h
>
> ~/Local/mess/37/telepathy-mission-control/src
> $ rm _gen/gtypes* -f
>
> ~/Local/mess/37/telepathy-mission-control/src
> $ make _gen/gtypes.h
> /usr/bin/python ../tools/glib-gtypes-generator.py \
> _gen/mcd.xml _gen/gtypes mc
>
> ~/Local/mess/37/telepathy-mission-control/src
> $ ls _gen/gtypes*
> _gen/gtypes-body.h _gen/gtypes.h
>
> The anti-pattern of:
>
> foo bar:
> this-script-generates-both-files.sh
>
> is wrong in parallel builds.
>
> Ross
>
>
next prev parent reply other threads:[~2013-09-18 2:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 8:49 [PATCH 0/1] telepathy-mission-control: do_compile failed (race issue) Robert Yang
2013-09-14 8:49 ` [PATCH 1/1] " Robert Yang
2013-09-16 23:08 ` Burton, Ross
2013-09-16 23:49 ` Burton, Ross
2013-09-17 2:03 ` Robert Yang
2013-09-17 11:12 ` Burton, Ross
2013-09-18 2:45 ` Robert Yang [this message]
2013-09-18 6:24 ` Burton, Ross
-- strict thread matches above, loose matches on Subject: below --
2013-09-23 5:54 [PATCH 0/1 V2] " Robert Yang
2013-09-23 5:54 ` [PATCH 1/1] " Robert Yang
2013-09-23 14:07 ` Burton, Ross
2013-09-24 1:35 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523913CD.3080104@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.