All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [munlock] BUG: Bad page map in process killall5 pte:53425553 pmd:075f4067
Date: Tue, 17 Sep 2013 15:34:17 +0200	[thread overview]
Message-ID: <52385A59.2080304@suse.cz> (raw)
In-Reply-To: <20130917132910.GA16186@localhost>

On 09/17/2013 03:29 PM, Fengguang Wu wrote:
> Hi Vlastimil,
> 
>>
>> Also, some of the failures during bisect were not due to this bug, but a WARNING for
>> list_add corruption which hopefully is not related to munlock. While it is probably a far stretch,
>> some kind of memory corruption could also lead to the erroneous behavior of the munlock code.
>>
>> Can you therefore please retest with the bisected patch reverted (patch below) to see if the other
>> WARNING still occurs and can be dealt with separately, so there are not potentially two bugs to
>> be chased at the same time?
> 
> Yes there seems to be one more bug, the attached dmesg is for the
> kernel with your patch reverted. I'm trying to bisect the other bug
> now.

Thanks. Meanwhile I was able to reproduce the bug in my patch in a VM
with x86_32 without PAE. As it turns out, pmd_addr_end() on such
configuration without pmd really does not bound the address to page
table boundary, but is a no-op. Working on a fix.

Vlastimil

> Thanks,
> Fengguang
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [munlock] BUG: Bad page map in process killall5 pte:53425553 pmd:075f4067
Date: Tue, 17 Sep 2013 15:34:17 +0200	[thread overview]
Message-ID: <52385A59.2080304@suse.cz> (raw)
In-Reply-To: <20130917132910.GA16186@localhost>

On 09/17/2013 03:29 PM, Fengguang Wu wrote:
> Hi Vlastimil,
> 
>>
>> Also, some of the failures during bisect were not due to this bug, but a WARNING for
>> list_add corruption which hopefully is not related to munlock. While it is probably a far stretch,
>> some kind of memory corruption could also lead to the erroneous behavior of the munlock code.
>>
>> Can you therefore please retest with the bisected patch reverted (patch below) to see if the other
>> WARNING still occurs and can be dealt with separately, so there are not potentially two bugs to
>> be chased at the same time?
> 
> Yes there seems to be one more bug, the attached dmesg is for the
> kernel with your patch reverted. I'm trying to bisect the other bug
> now.

Thanks. Meanwhile I was able to reproduce the bug in my patch in a VM
with x86_32 without PAE. As it turns out, pmd_addr_end() on such
configuration without pmd really does not bound the address to page
table boundary, but is a no-op. Working on a fix.

Vlastimil

> Thanks,
> Fengguang
> 


  reply	other threads:[~2013-09-17 13:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16  8:47 [munlock] BUG: Bad page map in process killall5 pte:53425553 pmd:075f4067 Fengguang Wu
2013-09-16  8:47 ` Fengguang Wu
2013-09-16 15:27 ` Vlastimil Babka
2013-09-16 15:27   ` Vlastimil Babka
2013-09-17 13:29   ` Fengguang Wu
2013-09-17 13:34     ` Vlastimil Babka [this message]
2013-09-17 13:34       ` Vlastimil Babka
2013-09-17 14:22       ` [RFC PATCH RESEND] mm: munlock: Prevent walking off the end of a pagetable in no-pmd configuration Vlastimil Babka
2013-09-17 14:22         ` Vlastimil Babka
2013-09-18  1:17         ` Bob Liu
2013-09-18  1:17           ` Bob Liu
2013-09-20  9:04           ` Vlastimil Babka
2013-09-20  9:04             ` Vlastimil Babka
2013-09-20  9:16 ` [PATCH] " Vlastimil Babka
2013-09-20  9:16   ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52385A59.2080304@suse.cz \
    --to=vbabka@suse.cz \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.