From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: si570: Add a driver for SI570 oscillators
Date: Tue, 17 Sep 2013 10:14:01 -0600 [thread overview]
Message-ID: <52387FC9.1080905@wwwdotorg.org> (raw)
In-Reply-To: <52380BD5.8080105@gmail.com>
On 09/17/2013 01:59 AM, Sebastian Hesselbarth wrote:
> On 09/16/2013 08:37 PM, Stephen Warren wrote:
...
>> Perhaps if clock-frequency is specified, the driver should refuse to
>> provide anything else. If clock-frequency isn't specified, the driver
>> shouldn't touch the HW when it initializes, but should honor any
>> requests that come in from other drivers? That would maintain what I
>> feel is clock-frequency's connection to being a fixed clock.
>
> For the clk-si5351 programmable clock driver in mainline, it already
> uses "clock-frequency" for initial clock setup but allows to set it
> later on. IMHO that is ok, because from a initial point-of-view, an
> initial frequency is fixed. As soon as the driver takes over, the user
> is free to do whatever he wants and should not be limited by DT.
>
> But if we vote against that approach, we should probably also modifiy
> clk-si5351 accordingly.
I suppose that approach isn't unreasonable. So, if there's precedent for
it, this driver may as well follow it.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Hyun Kwon <hyunk@xilinx.com>, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
linux-arm-kernel@lists.infradead.org,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH] clk: si570: Add a driver for SI570 oscillators
Date: Tue, 17 Sep 2013 10:14:01 -0600 [thread overview]
Message-ID: <52387FC9.1080905@wwwdotorg.org> (raw)
In-Reply-To: <52380BD5.8080105@gmail.com>
On 09/17/2013 01:59 AM, Sebastian Hesselbarth wrote:
> On 09/16/2013 08:37 PM, Stephen Warren wrote:
...
>> Perhaps if clock-frequency is specified, the driver should refuse to
>> provide anything else. If clock-frequency isn't specified, the driver
>> shouldn't touch the HW when it initializes, but should honor any
>> requests that come in from other drivers? That would maintain what I
>> feel is clock-frequency's connection to being a fixed clock.
>
> For the clk-si5351 programmable clock driver in mainline, it already
> uses "clock-frequency" for initial clock setup but allows to set it
> later on. IMHO that is ok, because from a initial point-of-view, an
> initial frequency is fixed. As soon as the driver takes over, the user
> is free to do whatever he wants and should not be limited by DT.
>
> But if we vote against that approach, we should probably also modifiy
> clk-si5351 accordingly.
I suppose that approach isn't unreasonable. So, if there's precedent for
it, this driver may as well follow it.
next prev parent reply other threads:[~2013-09-17 16:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 0:55 [PATCH] SI570 clock driver Soren Brinkmann
2013-09-13 0:55 ` Soren Brinkmann
2013-09-13 0:55 ` [PATCH] clk: si570: Add a driver for SI570 oscillators Soren Brinkmann
2013-09-13 0:55 ` Soren Brinkmann
2013-09-13 0:55 ` Soren Brinkmann
2013-09-13 17:00 ` Guenter Roeck
2013-09-13 17:00 ` Guenter Roeck
2013-09-13 17:26 ` Sören Brinkmann
2013-09-13 17:26 ` Sören Brinkmann
2013-09-13 17:26 ` Sören Brinkmann
2013-09-13 19:48 ` Guenter Roeck
2013-09-13 19:48 ` Guenter Roeck
2013-09-13 21:05 ` Sören Brinkmann
2013-09-13 21:05 ` Sören Brinkmann
2013-09-13 21:05 ` Sören Brinkmann
2013-09-13 21:14 ` Guenter Roeck
2013-09-13 21:14 ` Guenter Roeck
2013-09-14 8:01 ` Sebastian Hesselbarth
2013-09-14 8:01 ` Sebastian Hesselbarth
2013-09-14 8:01 ` Sebastian Hesselbarth
2013-09-16 16:34 ` Stephen Warren
2013-09-16 16:34 ` Stephen Warren
2013-09-16 16:49 ` Guenter Roeck
2013-09-16 16:49 ` Guenter Roeck
2013-09-16 16:59 ` Stephen Warren
2013-09-16 16:59 ` Stephen Warren
2013-09-16 16:59 ` Stephen Warren
2013-09-16 17:35 ` Guenter Roeck
2013-09-16 17:35 ` Guenter Roeck
2013-09-16 17:35 ` Guenter Roeck
2013-09-16 18:37 ` Stephen Warren
2013-09-16 18:37 ` Stephen Warren
2013-09-16 18:37 ` Stephen Warren
2013-09-16 19:14 ` Guenter Roeck
2013-09-16 19:14 ` Guenter Roeck
2013-09-17 7:59 ` Sebastian Hesselbarth
2013-09-17 7:59 ` Sebastian Hesselbarth
2013-09-17 13:08 ` Guenter Roeck
2013-09-17 13:08 ` Guenter Roeck
2013-09-17 16:14 ` Stephen Warren [this message]
2013-09-17 16:14 ` Stephen Warren
2013-09-18 20:41 ` Sören Brinkmann
2013-09-18 20:41 ` Sören Brinkmann
2013-09-18 20:41 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52387FC9.1080905@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.