Re: [Qemu-devel] [PATCH] kvm: add set_one_reg/get_one_reg

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 09/18/2013 05:14 PM, Peter Maydell wrote:
> On 18 September 2013 05:21, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>  include/sysemu/kvm.h |  4 ++++
>>  kvm-all.c            | 31 +++++++++++++++++++++++++++++++
>>  2 files changed, 35 insertions(+)
>>
>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
>> index c7bc07b..b2d61e9 100644
>> --- a/include/sysemu/kvm.h
>> +++ b/include/sysemu/kvm.h
>> @@ -319,4 +319,8 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>>  void kvm_pc_gsi_handler(void *opaque, int n, int level);
>>  void kvm_pc_setup_irq_routing(bool pci_enabled);
>>  void kvm_init_irq_routing(KVMState *s);
>> +
>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
> 
> Doc comments, please.

What comments? Do not the function names speak for themselves already?



-- 
Alexey