From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "'Rafael J. Wysocki'" <rjw@sisk.pl>,
'Len Brown' <lenb@kernel.org>,
"Box, David E" <david.e.box@intel.com>,
"Zheng, Lv" <lv.zheng@intel.com>,
"'linux-acpi@vger.kernel.org'" <linux-acpi@vger.kernel.org>,
"'patches@linaro.org'" <patches@linaro.org>,
"'linaro-kernel@lists.linaro.org'"
<linaro-kernel@lists.linaro.org>,
"'linaro-acpi@lists.linaro.org'" <linaro-acpi@lists.linaro.org>
Subject: Re: [PATCH] ACPICA / hwreg: Use acpi_gbl_reduced_hardware to prevent accessing PM registers
Date: Wed, 18 Sep 2013 17:31:32 +0800 [thread overview]
Message-ID: <523972F4.9070703@linaro.org> (raw)
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E36FEEC56A@ORSMSX103.amr.corp.intel.com>
On 2013-9-17 1:26, Moore, Robert wrote:
> + #define ACPI_REDUCED_HARDWARE TRUE
>
> The intent of this feature is of course, to remove all code that is not needed -- specifically for hardware-reduced machines where the size of the kernel is important.
>
> On a larger machine, the hardware-reduced flag should be sufficient. However, I would think that the host OS would look at this flag and realize that it should not be doing certain ACPI hardware-related things up front, rather than later when it finds out that a write to some ACPI hardware fails because the hardware isn't there.
Do you mean we should change the ACPI device driver instead of changing the
ACPICA code? that would be a hard job, because hardware ACPI is used
everywhere.
Thanks
Hanjun
>
> This is not to say that it is probably a good thing to return an error from the ACPI hardware code in the hardware-reduced case.
>
> Bob
>
next prev parent reply other threads:[~2013-09-18 9:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 10:05 [PATCH] ACPICA / hwreg: Use acpi_gbl_reduced_hardware to prevent accessing PM registers Hanjun Guo
2013-09-13 13:07 ` Moore, Robert
2013-09-13 20:16 ` Moore, Robert
2013-09-16 2:40 ` Hanjun Guo
2013-09-16 17:26 ` Moore, Robert
2013-09-18 9:28 ` Hanjun Guo
2013-09-24 0:09 ` Zheng, Lv
2013-09-18 9:31 ` Hanjun Guo [this message]
2013-09-18 15:09 ` Moore, Robert
2013-09-19 2:37 ` Moore, Robert
2013-09-19 3:52 ` Duran, Leo
2013-09-19 4:42 ` Moore, Robert
2013-09-22 3:26 ` Hanjun Guo
2013-09-24 0:20 ` Zheng, Lv
2013-09-22 2:50 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523972F4.9070703@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=david.e.box@intel.com \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.