From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "'Rafael J. Wysocki'" <rjw@sisk.pl>,
'Len Brown' <lenb@kernel.org>,
"Box, David E" <david.e.box@intel.com>,
"Zheng, Lv" <lv.zheng@intel.com>,
"'linux-acpi@vger.kernel.org'" <linux-acpi@vger.kernel.org>,
"'patches@linaro.org'" <patches@linaro.org>,
"'linaro-kernel@lists.linaro.org'"
<linaro-kernel@lists.linaro.org>,
"'linaro-acpi@lists.linaro.org'" <linaro-acpi@lists.linaro.org>
Subject: Re: [PATCH] ACPICA / hwreg: Use acpi_gbl_reduced_hardware to prevent accessing PM registers
Date: Sun, 22 Sep 2013 11:26:33 +0800 [thread overview]
Message-ID: <523E6369.3050803@linaro.org> (raw)
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E36FEFEA4D@ORSMSX102.amr.corp.intel.com>
On 2013-9-19 10:37, Moore, Robert wrote:
> While we are at it, here is the *complete* list of ACPICA interfaces that are
> meaningless on a hardware-reduced platform. If we are going to dynamically
> disable some of these interfaces, we will need to disable all of them -- for
> completeness. So, this is actually not a trivial change.
Yes, you are right.
Actually, before I send this patch out, I searched all the ACPICA API on
a hardware-reduced platform as you did, I found some of them will finally call
acpi_hw_register_read/write(), so some of the ACPICA API do not need to change.
Some of these APIs are already disabled in linux kernel tree now, such as
acpi_enable():
acpi_status acpi_enable(void)
{
acpi_status status;
int retry;
ACPI_FUNCTION_TRACE(acpi_enable);
/* ACPI tables must be present */
if (!acpi_tb_tables_loaded()) {
return_ACPI_STATUS(AE_NO_ACPI_TABLES);
}
/* If the Hardware Reduced flag is set, machine is always in acpi mode */
if (acpi_gbl_reduced_hardware) {
return_ACPI_STATUS(AE_OK);
}
...
}
and some of them need to be disabled as you said.
>
> I'll let the linux experts chime in on this one.
> Bob
>
>
> AcpiInstallSciHandler
> AcpiRemoveSciHandler
> AcpiInstallGlobalEventHandler
> AcpiInstallFixedEventHandler
> AcpiRemoveFixedEventHandler
> AcpiInstallGpeHandler
> AcpiRemoveGpeHandler
> AcpiAcquireGlobalLock
> AcpiReleaseGlobalLock
> AcpiEnable
> AcpiDisable
> AcpiEnableEvent
> AcpiDisableEvent
> AcpiClearEvent
> AcpiGetEventStatus
> AcpiUpdateAllGpes
> AcpiEnableGpe
> AcpiDisableGpe
> AcpiSetGpe
> AcpiSetupGpeForWake
> AcpiSetGpeWakeMask
> AcpiClearGpe
> AcpiGetGpeStatus
> AcpiFinishGpe
> AcpiDisableAllGpes
> AcpiEnableAllRuntimeGpes
> AcpiInstallGpeBlock
> AcpiRemoveGpeBlock
> AcpiGetGpeDevice
> AcpiGetTimerResolution
> AcpiGetTimer
> AcpiGetTimerDuration
> AcpiReadBitRegister
> AcpiWriteBitRegister
> AcpiSetFirmwareWakingVector
> AcpiSetFirmwareWakingVector64
> AcpiEnterSleepStateS4bios
next prev parent reply other threads:[~2013-09-22 3:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 10:05 [PATCH] ACPICA / hwreg: Use acpi_gbl_reduced_hardware to prevent accessing PM registers Hanjun Guo
2013-09-13 13:07 ` Moore, Robert
2013-09-13 20:16 ` Moore, Robert
2013-09-16 2:40 ` Hanjun Guo
2013-09-16 17:26 ` Moore, Robert
2013-09-18 9:28 ` Hanjun Guo
2013-09-24 0:09 ` Zheng, Lv
2013-09-18 9:31 ` Hanjun Guo
2013-09-18 15:09 ` Moore, Robert
2013-09-19 2:37 ` Moore, Robert
2013-09-19 3:52 ` Duran, Leo
2013-09-19 4:42 ` Moore, Robert
2013-09-22 3:26 ` Hanjun Guo [this message]
2013-09-24 0:20 ` Zheng, Lv
2013-09-22 2:50 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523E6369.3050803@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=david.e.box@intel.com \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.