From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/4] drivers: of: add initialization code for dma reserved memory
Date: Wed, 18 Sep 2013 13:07:03 +0200 [thread overview]
Message-ID: <52398957.9010505@samsung.com> (raw)
In-Reply-To: <20130918034848.A8E76C42CF4@trevor.secretlab.ca>
On 9/18/2013 5:48 AM, Grant Likely wrote:
> On Mon, 16 Sep 2013 06:43:08 -0700, Grant Likely <grant.likely@secretlab.ca> wrote:
> > On Mon, Sep 16, 2013 at 12:25 AM, Benjamin Herrenschmidt
> > <benh@kernel.crashing.org> wrote:
> > > On Mon, 2013-09-16 at 09:12 +0200, Marek Szyprowski wrote:
> > >>
> > >> Fixing those issues requires further discussion. Frankly, right now I
> > >> really have no idea which way should I go. The /reserved-ranges node seems
> > >> to be easy to match particular reserved memory region with a given device.
> > >> I'm also not really convinced if it makes sense to add a code for finding
> > >> and matching a reserved memory region to every device driver, which might
> > >> need it. I would really like to get some more feedback on the Ben's
> > >> comment.
> > >>
> > >> In any case, the code will also change significantly, so I assume that the
> > >> best, what can be done now is to revert the current version and start from
> > >> the scratch with a new, complete proposal.
> > >
> > > Yes, let's do that. I will try to help. It shouldn't be that a big deal.
> >
> > I think we can get the concerns sorted quickly. I'm at meetings all
> > day today in SJC, but I'll take a look at it this evening. I'll be in
> > Edinburgh. We're holding an ARM summit at the same time so a bunch of
> > affected ARM folks will be there.
>
> After reading through the entirety of the other thread, I think this can
> be fixed. My preference would be to fix in now rather than waiting
> another cycle. If you haven't sent the revert yet then please hold off
> for a bit (I can't tell at the moment since I'm currently on an airplane
> and I didn't update my tree before leaving the ground).
I've didn't send revert yet, I can wait a few days more if you see that the
issues can be fixed instead of redoing all from scratch.
Best regards
--
Marek Szyprowski
Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
Laura Abbott <lauraa-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Michal Nazarewicz
<mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>,
Marc <marc.ceeeee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kyungmin Park
<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Sylwester Nawrocki
<s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Nishanth Peethambaran
<nishanth.p-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Ian Campbell
<ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v7 3/4] drivers: of: add initialization code for dma reserved memory
Date: Wed, 18 Sep 2013 13:07:03 +0200 [thread overview]
Message-ID: <52398957.9010505@samsung.com> (raw)
In-Reply-To: <20130918034848.A8E76C42CF4-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
On 9/18/2013 5:48 AM, Grant Likely wrote:
> On Mon, 16 Sep 2013 06:43:08 -0700, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
> > On Mon, Sep 16, 2013 at 12:25 AM, Benjamin Herrenschmidt
> > <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> wrote:
> > > On Mon, 2013-09-16 at 09:12 +0200, Marek Szyprowski wrote:
> > >>
> > >> Fixing those issues requires further discussion. Frankly, right now I
> > >> really have no idea which way should I go. The /reserved-ranges node seems
> > >> to be easy to match particular reserved memory region with a given device.
> > >> I'm also not really convinced if it makes sense to add a code for finding
> > >> and matching a reserved memory region to every device driver, which might
> > >> need it. I would really like to get some more feedback on the Ben's
> > >> comment.
> > >>
> > >> In any case, the code will also change significantly, so I assume that the
> > >> best, what can be done now is to revert the current version and start from
> > >> the scratch with a new, complete proposal.
> > >
> > > Yes, let's do that. I will try to help. It shouldn't be that a big deal.
> >
> > I think we can get the concerns sorted quickly. I'm at meetings all
> > day today in SJC, but I'll take a look at it this evening. I'll be in
> > Edinburgh. We're holding an ARM summit at the same time so a bunch of
> > affected ARM folks will be there.
>
> After reading through the entirety of the other thread, I think this can
> be fixed. My preference would be to fix in now rather than waiting
> another cycle. If you haven't sent the revert yet then please hold off
> for a bit (I can't tell at the moment since I'm currently on an airplane
> and I didn't update my tree before leaving the ground).
I've didn't send revert yet, I can wait a few days more if you see that the
issues can be fixed instead of redoing all from scratch.
Best regards
--
Marek Szyprowski
Samsung R&D Institute Poland
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-18 11:07 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 14:39 [PATCH v7 0/4] Device Tree support for CMA (Contiguous Memory Allocator) Marek Szyprowski
2013-08-26 14:39 ` Marek Szyprowski
2013-08-26 14:39 ` [PATCH v7 1/4] drivers: dma-contiguous: clean source code and prepare for device tree Marek Szyprowski
2013-08-26 14:39 ` Marek Szyprowski
2013-08-26 14:39 ` [PATCH v7 2/4] drivers: of: add function to scan fdt nodes given by path Marek Szyprowski
2013-08-26 14:39 ` Marek Szyprowski
2013-08-29 21:40 ` Grant Likely
2013-08-29 21:40 ` Grant Likely
2013-08-30 10:42 ` Marek Szyprowski
2013-08-30 10:42 ` Marek Szyprowski
2013-08-30 10:46 ` Grant Likely
2013-08-30 10:46 ` Grant Likely
2013-08-26 14:39 ` [PATCH v7 3/4] drivers: of: add initialization code for dma reserved memory Marek Szyprowski
2013-08-26 14:39 ` Marek Szyprowski
2013-08-29 22:46 ` Grant Likely
2013-08-29 22:46 ` Grant Likely
2013-08-30 12:39 ` Marek Szyprowski
2013-08-30 12:39 ` Marek Szyprowski
2013-08-30 20:26 ` Kumar Gala
2013-08-30 20:26 ` Kumar Gala
2013-09-09 16:01 ` Grant Likely
2013-09-09 16:01 ` Grant Likely
2013-09-10 19:53 ` Kumar Gala
2013-09-10 19:53 ` Kumar Gala
2013-09-15 12:48 ` Grant Likely
2013-09-15 12:48 ` Grant Likely
2013-09-12 18:22 ` Kumar Gala
2013-09-12 18:22 ` Kumar Gala
2013-09-15 12:50 ` Grant Likely
2013-09-15 12:50 ` Grant Likely
2013-09-16 7:12 ` Marek Szyprowski
2013-09-16 7:12 ` Marek Szyprowski
2013-09-16 7:25 ` Benjamin Herrenschmidt
2013-09-16 7:25 ` Benjamin Herrenschmidt
2013-09-16 13:43 ` Grant Likely
2013-09-16 13:43 ` Grant Likely
2013-09-18 3:48 ` Grant Likely
2013-09-18 3:48 ` Grant Likely
2013-09-18 11:07 ` Marek Szyprowski [this message]
2013-09-18 11:07 ` Marek Szyprowski
2013-09-16 8:17 ` Marek Szyprowski
2013-09-16 8:17 ` Marek Szyprowski
2013-09-09 13:05 ` Grant Likely
2013-09-09 13:05 ` Grant Likely
2013-08-29 22:48 ` Grant Likely
2013-08-29 22:48 ` Grant Likely
2013-09-27 15:47 ` Kumar Gala
2013-09-27 15:47 ` Kumar Gala
2013-09-27 17:06 ` Matt Sealey
2013-09-27 17:06 ` Matt Sealey
2013-08-26 14:39 ` [PATCH v7 4/4] ARM: init: add support for reserved memory defined by device tree Marek Szyprowski
2013-08-26 14:39 ` Marek Szyprowski
2013-08-29 22:49 ` Grant Likely
2013-08-29 22:49 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52398957.9010505@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.