* [PATCH ] net:dccp: do not report ICMP redirects to user space
@ 2013-09-18 12:03 Duan Jiong
2013-09-18 16:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Duan Jiong @ 2013-09-18 12:03 UTC (permalink / raw)
To: David Miller; +Cc: netdev, hannes
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
DCCP shouldn't be setting sk_err on redirects as it
isn't an error condition. it should be doing exactly
what tcp is doing and leaving the error handler without
touching the socket.
Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
net/dccp/ipv6.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c
index 9c61f9c..6cf9f77 100644
--- a/net/dccp/ipv6.c
+++ b/net/dccp/ipv6.c
@@ -135,6 +135,7 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
if (dst)
dst->ops->redirect(dst, sk, skb);
+ goto out;
}
if (type == ICMPV6_PKT_TOOBIG) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ] net:dccp: do not report ICMP redirects to user space
2013-09-18 12:03 [PATCH ] net:dccp: do not report ICMP redirects to user space Duan Jiong
@ 2013-09-18 16:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-09-18 16:34 UTC (permalink / raw)
To: duanj.fnst; +Cc: netdev, hannes
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Date: Wed, 18 Sep 2013 20:03:27 +0800
> From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
>
> DCCP shouldn't be setting sk_err on redirects as it
> isn't an error condition. it should be doing exactly
> what tcp is doing and leaving the error handler without
> touching the socket.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-18 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 12:03 [PATCH ] net:dccp: do not report ICMP redirects to user space Duan Jiong
2013-09-18 16:34 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.