Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status

[Peter Lieven <pl@kamp.de>]

On 17.09.2013 19:21, Paolo Bonzini wrote:
> Il 17/09/2013 19:18, Stefan Weil ha scritto:
>> Latest QEMU git is broken on Debian wheezy:
>>
>> block/iscsi.c: In function ‘iscsi_co_get_block_status’:
>> block/iscsi.c:842:5: error: implicit declaration of function
>> ‘iscsi_get_lba_status_task’ [-Werror=implicit-function-declaration]
>> block/iscsi.c:842:5: error: nested extern declaration of
>> ‘iscsi_get_lba_status_task’ [-Werror=nested-externs]
>> block/iscsi.c:845:43: error: comparison between pointer and integer
>> [-Werror]
>> block/iscsi.c:877:18: error: dereferencing pointer to incomplete type
>> block/iscsi.c:879:55: error: dereferencing pointer to incomplete type
>> block/iscsi.c:884:34: error: dereferencing pointer to incomplete type
>> block/iscsi.c:889:14: error: dereferencing pointer to incomplete type
>> block/iscsi.c:889:32: error: ‘SCSI_PROVISIONING_TYPE_DEALLOCATED’
>> undeclared (first use in this function)
>> block/iscsi.c:889:32: note: each undeclared identifier is reported only
>> once for each function it appears in
>> block/iscsi.c:890:14: error: dereferencing pointer to incomplete type
>> block/iscsi.c:890:32: error: ‘SCSI_PROVISIONING_TYPE_ANCHORED’
>> undeclared (first use in this function)
>> cc1: all warnings being treated as errors
>>
>> Debian includes libiscsi-dev 1.4.0 without a libiscsi.pk, so it uses a
>> compile test
>> which thinks that libiscsi is good enough.
>>
>> Did the latest changes raise the requirements for libscsi?
> Looks like.  Can you make a patch that drops the definition of
> iscsi_co_get_block_status if SCSI_PROVISIONING_TYPE_DEALLOCATED is not
> #defined?
>
> Thanks,
>
> Paolo
do we still need this patch? if yes I can sent one shortly.

Peter