From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Tim Deegan <tim@xen.org>
Cc: keir@xen.org, jbeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] x86: mark BUG()s and assertion failures as terminal.
Date: Thu, 19 Sep 2013 16:44:25 +0100 [thread overview]
Message-ID: <523B1BD9.5050801@citrix.com> (raw)
In-Reply-To: <1379601586-27173-1-git-send-email-tim@xen.org>
On 19/09/2013 15:39, Tim Deegan wrote:
> This helps avoid static analysis false-positives, and might lead to
> better code density as the compiler knows it doesn't have to restore
> spilled state &c.
>
> Signed-off-by: Tim Deegan <tim@xen.org>
>
Out of interest, I tried looking at some numbers for this.
Using gcc 4.7.2 (Debian Wheezy), .text decreased by 656 bytes and
.init.text decreased by 71 bytes. While those are expected, .rodata
decreased by 1224 bytes. I am at a loss to explain the decrease in
.rodata, but did double check my compiling, and find the decrease still
present.
Either way, it looks to be a useful improvement.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2013-09-19 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 14:39 [PATCH] x86: mark BUG()s and assertion failures as terminal Tim Deegan
2013-09-19 14:56 ` Keir Fraser
2013-09-19 15:07 ` Tim Deegan
2013-09-19 15:10 ` Tim Deegan
2013-09-19 15:17 ` Keir Fraser
2013-09-19 15:13 ` Keir Fraser
2013-09-19 15:44 ` Andrew Cooper [this message]
2013-09-19 16:52 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B1BD9.5050801@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.