Re: [Qemu-devel] [PATCH 1/2] blockdev: do not default cache.no-flush to true

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On 09/19/2013 10:48 AM, Paolo Bonzini wrote:
> That's why all my VMs were so fast lately. :)
> 
> This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up
> 'cache' option, 2013-07-18).

And my name is tied to that one as a reviewer.  Sorry for letting it
through in the first place.

> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  blockdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/blockdev.c b/blockdev.c
> index 07dac05..76bfe30 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -443,7 +443,7 @@ static DriveInfo *blockdev_init(QemuOpts *all_opts,
>      if (qemu_opt_get_bool(opts, "cache.direct", false)) {
>          bdrv_flags |= BDRV_O_NOCACHE;
>      }
> -    if (qemu_opt_get_bool(opts, "cache.no-flush", true)) {
> +    if (qemu_opt_get_bool(opts, "cache.no-flush", false)) {
>          bdrv_flags |= BDRV_O_NO_FLUSH;
>      }
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]