From: Marc Pignat <marc.pignat@hevs.ch>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata
Date: Fri, 20 Sep 2013 08:23:03 +0000 [thread overview]
Message-ID: <523C05E7.1000407@hevs.ch> (raw)
In-Reply-To: <1379650002-13127-1-git-send-email-sachin.kamat@linaro.org>
Acked-by: Marc Pignat <marc.pignat@hevs.ch>
On 09/20/2013 06:06 AM, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Marc Pignat <marc.pignat@hevs.ch>
> ---
> compile tested.
> ---
> drivers/hwmon/adcxx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/adcxx.c b/drivers/hwmon/adcxx.c
> index 751b1f0..04c08c2 100644
> --- a/drivers/hwmon/adcxx.c
> +++ b/drivers/hwmon/adcxx.c
> @@ -203,7 +203,6 @@ out_err:
> for (i--; i >= 0; i--)
> device_remove_file(&spi->dev, &ad_input[i].dev_attr);
>
> - spi_set_drvdata(spi, NULL);
> mutex_unlock(&adc->lock);
> return status;
> }
> @@ -218,7 +217,6 @@ static int adcxx_remove(struct spi_device *spi)
> for (i = 0; i < 3 + adc->channels; i++)
> device_remove_file(&spi->dev, &ad_input[i].dev_attr);
>
> - spi_set_drvdata(spi, NULL);
> mutex_unlock(&adc->lock);
>
> return 0;
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-09-20 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 4:18 [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata Sachin Kamat
2013-09-20 8:23 ` Marc Pignat [this message]
2013-09-20 13:53 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C05E7.1000407@hevs.ch \
--to=marc.pignat@hevs.ch \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.