* [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata
@ 2013-09-20 4:18 Sachin Kamat
2013-09-20 8:23 ` Marc Pignat
2013-09-20 13:53 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-20 4:18 UTC (permalink / raw)
To: lm-sensors
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Marc Pignat <marc.pignat@hevs.ch>
---
compile tested.
---
drivers/hwmon/adcxx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hwmon/adcxx.c b/drivers/hwmon/adcxx.c
index 751b1f0..04c08c2 100644
--- a/drivers/hwmon/adcxx.c
+++ b/drivers/hwmon/adcxx.c
@@ -203,7 +203,6 @@ out_err:
for (i--; i >= 0; i--)
device_remove_file(&spi->dev, &ad_input[i].dev_attr);
- spi_set_drvdata(spi, NULL);
mutex_unlock(&adc->lock);
return status;
}
@@ -218,7 +217,6 @@ static int adcxx_remove(struct spi_device *spi)
for (i = 0; i < 3 + adc->channels; i++)
device_remove_file(&spi->dev, &ad_input[i].dev_attr);
- spi_set_drvdata(spi, NULL);
mutex_unlock(&adc->lock);
return 0;
--
1.7.9.5
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata
2013-09-20 4:18 [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata Sachin Kamat
@ 2013-09-20 8:23 ` Marc Pignat
2013-09-20 13:53 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Marc Pignat @ 2013-09-20 8:23 UTC (permalink / raw)
To: lm-sensors
Acked-by: Marc Pignat <marc.pignat@hevs.ch>
On 09/20/2013 06:06 AM, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Marc Pignat <marc.pignat@hevs.ch>
> ---
> compile tested.
> ---
> drivers/hwmon/adcxx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/adcxx.c b/drivers/hwmon/adcxx.c
> index 751b1f0..04c08c2 100644
> --- a/drivers/hwmon/adcxx.c
> +++ b/drivers/hwmon/adcxx.c
> @@ -203,7 +203,6 @@ out_err:
> for (i--; i >= 0; i--)
> device_remove_file(&spi->dev, &ad_input[i].dev_attr);
>
> - spi_set_drvdata(spi, NULL);
> mutex_unlock(&adc->lock);
> return status;
> }
> @@ -218,7 +217,6 @@ static int adcxx_remove(struct spi_device *spi)
> for (i = 0; i < 3 + adc->channels; i++)
> device_remove_file(&spi->dev, &ad_input[i].dev_attr);
>
> - spi_set_drvdata(spi, NULL);
> mutex_unlock(&adc->lock);
>
> return 0;
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata
2013-09-20 4:18 [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata Sachin Kamat
2013-09-20 8:23 ` Marc Pignat
@ 2013-09-20 13:53 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-09-20 13:53 UTC (permalink / raw)
To: lm-sensors
On Fri, Sep 20, 2013 at 09:36:41AM +0530, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Marc Pignat <marc.pignat@hevs.ch>
Applied to -next.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-20 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 4:18 [lm-sensors] [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata Sachin Kamat
2013-09-20 8:23 ` Marc Pignat
2013-09-20 13:53 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.