From: Nishanth Menon <nm@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
linux-doc@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Kevin Hilman <khilman@deeprootsystems.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Randy Dunlap <rdunlap@infradead.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Rob Landley <rob@landley.net>,
linux-omap@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*
Date: Fri, 20 Sep 2013 14:07:17 -0500 [thread overview]
Message-ID: <523C9CE5.9040009@ti.com> (raw)
In-Reply-To: <CAKohpoktS4ZSQAeKvu3hdVsKkzcbKFvHvR2=wCA3qeB6moPphA@mail.gmail.com>
On 09/20/2013 11:51 AM, Viresh Kumar wrote:
> On 20 September 2013 18:08, Nishanth Menon <nm@ti.com> wrote:
>
>> I am open to suggestions if any one feels we can improve this better.
>
> I didn't really had one.. I thought of pm_opp** instead of dev_pm_opp**
> though..
I had proposed this earlier, however, had gone with Rafael's
suggestion [1] to have the right context to the usage.
>
>> I believe that change was from Patch #2[1]
>
> Yeah.. I just replied on a single patch :)
>
>> yes, you are right, I had squashed this patch in to squelch checkpatch
>> warnings:
>
> I see..
>
>> I had added a comment:
>> " Minor checkpatch warning fixes as a result of this change was fixed as
>> well."
>
> I really missed that..
no problems..
>
>> Would you suggest I split the change off to a separate patch or improve
>> the comment a little more?
>
> don't really know, maybe leave those as is and let checkpatch warn you..
>
that is fair as well. i can split it off seperately in the next respin.
[1] http://marc.info/?l=linaro-kernel&m=137645747511725&w=2
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*
Date: Fri, 20 Sep 2013 14:07:17 -0500 [thread overview]
Message-ID: <523C9CE5.9040009@ti.com> (raw)
In-Reply-To: <CAKohpoktS4ZSQAeKvu3hdVsKkzcbKFvHvR2=wCA3qeB6moPphA@mail.gmail.com>
On 09/20/2013 11:51 AM, Viresh Kumar wrote:
> On 20 September 2013 18:08, Nishanth Menon <nm@ti.com> wrote:
>
>> I am open to suggestions if any one feels we can improve this better.
>
> I didn't really had one.. I thought of pm_opp** instead of dev_pm_opp**
> though..
I had proposed this earlier, however, had gone with Rafael's
suggestion [1] to have the right context to the usage.
>
>> I believe that change was from Patch #2[1]
>
> Yeah.. I just replied on a single patch :)
>
>> yes, you are right, I had squashed this patch in to squelch checkpatch
>> warnings:
>
> I see..
>
>> I had added a comment:
>> " Minor checkpatch warning fixes as a result of this change was fixed as
>> well."
>
> I really missed that..
no problems..
>
>> Would you suggest I split the change off to a separate patch or improve
>> the comment a little more?
>
> don't really know, maybe leave those as is and let checkpatch warn you..
>
that is fair as well. i can split it off seperately in the next respin.
[1] http://marc.info/?l=linaro-kernel&m=137645747511725&w=2
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Rob Landley <rob@landley.net>, Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>,
Russell King <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>,
Kukjin Kim <kgene.kim@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*
Date: Fri, 20 Sep 2013 14:07:17 -0500 [thread overview]
Message-ID: <523C9CE5.9040009@ti.com> (raw)
In-Reply-To: <CAKohpoktS4ZSQAeKvu3hdVsKkzcbKFvHvR2=wCA3qeB6moPphA@mail.gmail.com>
On 09/20/2013 11:51 AM, Viresh Kumar wrote:
> On 20 September 2013 18:08, Nishanth Menon <nm@ti.com> wrote:
>
>> I am open to suggestions if any one feels we can improve this better.
>
> I didn't really had one.. I thought of pm_opp** instead of dev_pm_opp**
> though..
I had proposed this earlier, however, had gone with Rafael's
suggestion [1] to have the right context to the usage.
>
>> I believe that change was from Patch #2[1]
>
> Yeah.. I just replied on a single patch :)
>
>> yes, you are right, I had squashed this patch in to squelch checkpatch
>> warnings:
>
> I see..
>
>> I had added a comment:
>> " Minor checkpatch warning fixes as a result of this change was fixed as
>> well."
>
> I really missed that..
no problems..
>
>> Would you suggest I split the change off to a separate patch or improve
>> the comment a little more?
>
> don't really know, maybe leave those as is and let checkpatch warn you..
>
that is fair as well. i can split it off seperately in the next respin.
[1] http://marc.info/?l=linaro-kernel&m=137645747511725&w=2
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-09-20 19:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 21:03 [PATCH 0/3] PM / OPP: rename to dev_pm_opp * equivalents Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-19 21:03 ` [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp* Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-20 7:14 ` Viresh Kumar
2013-09-20 7:14 ` Viresh Kumar
2013-09-20 12:38 ` Nishanth Menon
2013-09-20 12:38 ` Nishanth Menon
2013-09-20 12:38 ` Nishanth Menon
2013-09-20 16:51 ` Viresh Kumar
2013-09-20 16:51 ` Viresh Kumar
2013-09-20 19:07 ` Nishanth Menon [this message]
2013-09-20 19:07 ` Nishanth Menon
2013-09-20 19:07 ` Nishanth Menon
2013-09-19 21:03 ` [PATCH 2/3] PM / OPP: rename data structures to dev_pm equivalents Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-19 21:03 ` [PATCH 3/3] PM / OPP: rename header to linux/pm_opp.h Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-19 21:03 ` Nishanth Menon
2013-09-19 21:14 ` [PATCH 0/3] PM / OPP: rename to dev_pm_opp * equivalents Nishanth Menon
2013-09-19 21:14 ` Nishanth Menon
2013-09-19 21:14 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C9CE5.9040009@ti.com \
--to=nm@ti.com \
--cc=cpufreq@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=khilman@deeprootsystems.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=myungjoo.ham@samsung.com \
--cc=rdunlap@infradead.org \
--cc=rjw@sisk.pl \
--cc=rob@landley.net \
--cc=shawn.guo@linaro.org \
--cc=sudeep.karkadanagesha@arm.com \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.