From: Josh Wu <josh.wu@atmel.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH v3] mtd: atmel_nand: use minimum ecc requirements of nand: ecc_{strength,step}_ds
Date: Sun, 22 Sep 2013 11:52:35 +0800 [thread overview]
Message-ID: <523E6983.3030203@atmel.com> (raw)
In-Reply-To: <20130919224154.GT4550@ld-irv-0074.broadcom.com>
Dear Brian
On 9/20/2013 6:41 AM, Brian Norris wrote:
> On Wed, Sep 18, 2013 at 02:42:25PM -0700, Brian Norris wrote:
>> On Wed, Sep 18, 2013 at 01:58:48PM +0800, Josh Wu wrote:
>>> Since ecc_{strength,step}_ds is introduced in nand_chip structure for
>>> minimum ecc requirements. So we can use them directly and remove our
>>> own get_onfi_ecc_param function.
>>>
>>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ...
>> I'll just apply the appended diff, to address these small comments and
>> to shorten the messages a little (they are a bit verbose and are over 80
>> characters). It's still not under 80, but it's more reasonable.
>>
>> Let me know if you have any objections, or else I'll push this to
>> l2-mtd.git.
Just back to office, no objections of cause and thank you for the
modification to fix my typos and sentence.
> Pushed to l2-mtd.git. Thanks!
>
> Brian
Best Regards,
Josh Wu
WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] mtd: atmel_nand: use minimum ecc requirements of nand: ecc_{strength,step}_ds
Date: Sun, 22 Sep 2013 11:52:35 +0800 [thread overview]
Message-ID: <523E6983.3030203@atmel.com> (raw)
In-Reply-To: <20130919224154.GT4550@ld-irv-0074.broadcom.com>
Dear Brian
On 9/20/2013 6:41 AM, Brian Norris wrote:
> On Wed, Sep 18, 2013 at 02:42:25PM -0700, Brian Norris wrote:
>> On Wed, Sep 18, 2013 at 01:58:48PM +0800, Josh Wu wrote:
>>> Since ecc_{strength,step}_ds is introduced in nand_chip structure for
>>> minimum ecc requirements. So we can use them directly and remove our
>>> own get_onfi_ecc_param function.
>>>
>>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ...
>> I'll just apply the appended diff, to address these small comments and
>> to shorten the messages a little (they are a bit verbose and are over 80
>> characters). It's still not under 80, but it's more reasonable.
>>
>> Let me know if you have any objections, or else I'll push this to
>> l2-mtd.git.
Just back to office, no objections of cause and thank you for the
modification to fix my typos and sentence.
> Pushed to l2-mtd.git. Thanks!
>
> Brian
Best Regards,
Josh Wu
next prev parent reply other threads:[~2013-09-22 3:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 5:58 [PATCH v3] mtd: atmel_nand: use minimum ecc requirements of nand: ecc_{strength, step}_ds Josh Wu
2013-09-18 5:58 ` Josh Wu
2013-09-18 21:42 ` [PATCH v3] mtd: atmel_nand: use minimum ecc requirements of nand: ecc_{strength,step}_ds Brian Norris
2013-09-18 21:42 ` Brian Norris
2013-09-19 22:41 ` Brian Norris
2013-09-19 22:41 ` Brian Norris
2013-09-22 3:52 ` Josh Wu [this message]
2013-09-22 3:52 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523E6983.3030203@atmel.com \
--to=josh.wu@atmel.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.