From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/8 V3] rtlwifi: rtl8192de: Fix smatch warnings in rtl8192de/hw.c
Date: Sun, 22 Sep 2013 23:09:31 +0400 [thread overview]
Message-ID: <523F406B.2010708@cogentembedded.com> (raw)
In-Reply-To: <1379534260-14841-3-git-send-email-Larry.Finger@lwfinger.net>
Hello.
On 09/18/2013 11:57 PM, Larry Finger wrote:
> Smatch lists the following:
> CHECK drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code.
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code.
> The dead code is deleted.
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 19 -------------------
> 1 file changed, 19 deletions(-)
> Index: wireless-testing-save/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> ===================================================================
> --- wireless-testing-save.orig/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> +++ wireless-testing-save/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> @@ -1194,25 +1194,6 @@ void rtl92d_linked_set_reg(struct ieee80
> * mac80211 will send pkt when scan */
> void rtl92de_set_qos(struct ieee80211_hw *hw, int aci)
> {
> - struct rtl_priv *rtlpriv = rtl_priv(hw);
> - rtl92d_dm_init_edca_turbo(hw);
This call seems reachable...
> - return;
> - switch (aci) {
> - case AC1_BK:
> - rtl_write_dword(rtlpriv, REG_EDCA_BK_PARAM, 0xa44f);
> - break;
> - case AC0_BE:
> - break;
> - case AC2_VI:
> - rtl_write_dword(rtlpriv, REG_EDCA_VI_PARAM, 0x5e4322);
> - break;
> - case AC3_VO:
> - rtl_write_dword(rtlpriv, REG_EDCA_VO_PARAM, 0x2f3222);
> - break;
> - default:
> - RT_ASSERT(false, "invalid aci: %d !\n", aci);
> - break;
> - }
> }
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/8 V3] rtlwifi: rtl8192de: Fix smatch warnings in rtl8192de/hw.c
Date: Sun, 22 Sep 2013 23:09:31 +0400 [thread overview]
Message-ID: <523F406B.2010708@cogentembedded.com> (raw)
In-Reply-To: <1379534260-14841-3-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Hello.
On 09/18/2013 11:57 PM, Larry Finger wrote:
> Smatch lists the following:
> CHECK drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code.
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c:1200 rtl92de_set_qos() info: ignoring unreachable code.
> The dead code is deleted.
> Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
> ---
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 19 -------------------
> 1 file changed, 19 deletions(-)
> Index: wireless-testing-save/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> ===================================================================
> --- wireless-testing-save.orig/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> +++ wireless-testing-save/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> @@ -1194,25 +1194,6 @@ void rtl92d_linked_set_reg(struct ieee80
> * mac80211 will send pkt when scan */
> void rtl92de_set_qos(struct ieee80211_hw *hw, int aci)
> {
> - struct rtl_priv *rtlpriv = rtl_priv(hw);
> - rtl92d_dm_init_edca_turbo(hw);
This call seems reachable...
> - return;
> - switch (aci) {
> - case AC1_BK:
> - rtl_write_dword(rtlpriv, REG_EDCA_BK_PARAM, 0xa44f);
> - break;
> - case AC0_BE:
> - break;
> - case AC2_VI:
> - rtl_write_dword(rtlpriv, REG_EDCA_VI_PARAM, 0x5e4322);
> - break;
> - case AC3_VO:
> - rtl_write_dword(rtlpriv, REG_EDCA_VO_PARAM, 0x2f3222);
> - break;
> - default:
> - RT_ASSERT(false, "invalid aci: %d !\n", aci);
> - break;
> - }
> }
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-22 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 19:57 [PATCH 0/8 V3] rtlwifi: Patches to fix problems shown by smatch Larry Finger
2013-09-18 19:57 ` Larry Finger
2013-09-18 19:57 ` [PATCH 1/8 V3] rtlwifi: rtl8192du: Fix smatch errors in /rtl8192de/dm.c Larry Finger
2013-09-18 19:57 ` [PATCH 2/8 V3] rtlwifi: rtl8192de: Fix smatch warnings in rtl8192de/hw.c Larry Finger
2013-09-18 19:57 ` Larry Finger
2013-09-22 19:09 ` Sergei Shtylyov [this message]
2013-09-22 19:09 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523F406B.2010708@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.