All of lore.kernel.org
 help / color / mirror / Atom feed
From: matt.porter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: add initial VF610 Cosmic/Cosmic+ board support
Date: Mon, 23 Sep 2013 10:56:56 -0400	[thread overview]
Message-ID: <524056B8.4020208@linaro.org> (raw)
In-Reply-To: <20130922070138.GC31787@S2101-09.ap.freescale.net>

On 09/22/2013 03:01 AM, Shawn Guo wrote:
> On Thu, Sep 19, 2013 at 08:40:44AM -0400, Matt Porter wrote:
>> Add initial PHYTEC VF610 Cosmic/Cosmic+ board support with
>> UART and FEC enabled.
>>
>> Signed-off-by: Matt Porter <matt.porter@linaro.org>
>> ---
>>   arch/arm/boot/dts/Makefile         |  1 +
>>   arch/arm/boot/dts/vf610-cosmic.dts | 46 ++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 47 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/vf610-cosmic.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index cc0f1fb..b0d6156 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>>   	imx6q-sbc6x.dtb \
>>   	imx6q-wandboard.dtb \
>>   	imx6sl-evk.dtb \
>> +	vf610-cosmic.dtb \
>>   	vf610-twr.dtb
>>   dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
>>   	imx23-olinuxino.dtb \
>> diff --git a/arch/arm/boot/dts/vf610-cosmic.dts b/arch/arm/boot/dts/vf610-cosmic.dts
>> new file mode 100644
>> index 0000000..c3bd4d4f
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/vf610-cosmic.dts
>> @@ -0,0 +1,46 @@
>> +/*
>> + * Copyright 2013 Freescale Semiconductor, Inc.
>> + * Copyright 2013 Linaro Limited
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
>> +
>> +/dts-v1/;
>> +#include "vf610.dtsi"
>> +
>> +/ {
>> +	model = "PHYTEC Cosmic/Cosmic+ Board";
>> +	compatible = "phytec,vf610-cosmic", "fsl,vf610";
>> +
>> +	chosen {
>> +		bootargs = "console=ttyLP1,115200";
>> +	};
>> +
>> +	memory {
>> +		reg = <0x80000000 0x10000000>;
>> +	};
>> +
>> +	clocks {
>> +		enet_ext {
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <50000000>;
>> +		};
>
> This is probably copied from vf610-twr.dts.  But per
> Documentation/devicetree/bindings/clock/fixed-clock.txt, #clock-cells is
> a required property.

Indeed, will update it.

>
>> +	};
>> +
>> +};
>> +
>> +&uart1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart1_1>;
>> +	status = "okay";
>> +};
>> +
>> +&fec1 {
>
> Please sort the nodes alphabetically in label name.

Will do.

Thanks,
Matt

WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Devicetree List
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux ARM Kernel List
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linaro Patches <patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: add initial VF610 Cosmic/Cosmic+ board support
Date: Mon, 23 Sep 2013 10:56:56 -0400	[thread overview]
Message-ID: <524056B8.4020208@linaro.org> (raw)
In-Reply-To: <20130922070138.GC31787-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>

On 09/22/2013 03:01 AM, Shawn Guo wrote:
> On Thu, Sep 19, 2013 at 08:40:44AM -0400, Matt Porter wrote:
>> Add initial PHYTEC VF610 Cosmic/Cosmic+ board support with
>> UART and FEC enabled.
>>
>> Signed-off-by: Matt Porter <matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/Makefile         |  1 +
>>   arch/arm/boot/dts/vf610-cosmic.dts | 46 ++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 47 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/vf610-cosmic.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index cc0f1fb..b0d6156 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>>   	imx6q-sbc6x.dtb \
>>   	imx6q-wandboard.dtb \
>>   	imx6sl-evk.dtb \
>> +	vf610-cosmic.dtb \
>>   	vf610-twr.dtb
>>   dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
>>   	imx23-olinuxino.dtb \
>> diff --git a/arch/arm/boot/dts/vf610-cosmic.dts b/arch/arm/boot/dts/vf610-cosmic.dts
>> new file mode 100644
>> index 0000000..c3bd4d4f
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/vf610-cosmic.dts
>> @@ -0,0 +1,46 @@
>> +/*
>> + * Copyright 2013 Freescale Semiconductor, Inc.
>> + * Copyright 2013 Linaro Limited
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
>> +
>> +/dts-v1/;
>> +#include "vf610.dtsi"
>> +
>> +/ {
>> +	model = "PHYTEC Cosmic/Cosmic+ Board";
>> +	compatible = "phytec,vf610-cosmic", "fsl,vf610";
>> +
>> +	chosen {
>> +		bootargs = "console=ttyLP1,115200";
>> +	};
>> +
>> +	memory {
>> +		reg = <0x80000000 0x10000000>;
>> +	};
>> +
>> +	clocks {
>> +		enet_ext {
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <50000000>;
>> +		};
>
> This is probably copied from vf610-twr.dts.  But per
> Documentation/devicetree/bindings/clock/fixed-clock.txt, #clock-cells is
> a required property.

Indeed, will update it.

>
>> +	};
>> +
>> +};
>> +
>> +&uart1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart1_1>;
>> +	status = "okay";
>> +};
>> +
>> +&fec1 {
>
> Please sort the nodes alphabetically in label name.

Will do.

Thanks,
Matt

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <matt.porter@linaro.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linaro Patches <patches@linaro.org>
Subject: Re: [PATCH] ARM: dts: add initial VF610 Cosmic/Cosmic+ board support
Date: Mon, 23 Sep 2013 10:56:56 -0400	[thread overview]
Message-ID: <524056B8.4020208@linaro.org> (raw)
In-Reply-To: <20130922070138.GC31787@S2101-09.ap.freescale.net>

On 09/22/2013 03:01 AM, Shawn Guo wrote:
> On Thu, Sep 19, 2013 at 08:40:44AM -0400, Matt Porter wrote:
>> Add initial PHYTEC VF610 Cosmic/Cosmic+ board support with
>> UART and FEC enabled.
>>
>> Signed-off-by: Matt Porter <matt.porter@linaro.org>
>> ---
>>   arch/arm/boot/dts/Makefile         |  1 +
>>   arch/arm/boot/dts/vf610-cosmic.dts | 46 ++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 47 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/vf610-cosmic.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index cc0f1fb..b0d6156 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>>   	imx6q-sbc6x.dtb \
>>   	imx6q-wandboard.dtb \
>>   	imx6sl-evk.dtb \
>> +	vf610-cosmic.dtb \
>>   	vf610-twr.dtb
>>   dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
>>   	imx23-olinuxino.dtb \
>> diff --git a/arch/arm/boot/dts/vf610-cosmic.dts b/arch/arm/boot/dts/vf610-cosmic.dts
>> new file mode 100644
>> index 0000000..c3bd4d4f
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/vf610-cosmic.dts
>> @@ -0,0 +1,46 @@
>> +/*
>> + * Copyright 2013 Freescale Semiconductor, Inc.
>> + * Copyright 2013 Linaro Limited
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
>> +
>> +/dts-v1/;
>> +#include "vf610.dtsi"
>> +
>> +/ {
>> +	model = "PHYTEC Cosmic/Cosmic+ Board";
>> +	compatible = "phytec,vf610-cosmic", "fsl,vf610";
>> +
>> +	chosen {
>> +		bootargs = "console=ttyLP1,115200";
>> +	};
>> +
>> +	memory {
>> +		reg = <0x80000000 0x10000000>;
>> +	};
>> +
>> +	clocks {
>> +		enet_ext {
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <50000000>;
>> +		};
>
> This is probably copied from vf610-twr.dts.  But per
> Documentation/devicetree/bindings/clock/fixed-clock.txt, #clock-cells is
> a required property.

Indeed, will update it.

>
>> +	};
>> +
>> +};
>> +
>> +&uart1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart1_1>;
>> +	status = "okay";
>> +};
>> +
>> +&fec1 {
>
> Please sort the nodes alphabetically in label name.

Will do.

Thanks,
Matt


  reply	other threads:[~2013-09-23 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 12:40 [PATCH] ARM: dts: add initial VF610 Cosmic/Cosmic+ board support Matt Porter
2013-09-19 12:40 ` Matt Porter
2013-09-19 12:40 ` Matt Porter
2013-09-22  7:01 ` Shawn Guo
2013-09-22  7:01   ` Shawn Guo
2013-09-22  7:01   ` Shawn Guo
2013-09-23 14:56   ` Matt Porter [this message]
2013-09-23 14:56     ` Matt Porter
2013-09-23 14:56     ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524056B8.4020208@linaro.org \
    --to=matt.porter@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.