From: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>
To: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Cc: bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
Date: Mon, 23 Sep 2013 20:58:48 +0530 [thread overview]
Message-ID: <52405E30.2020001@ti.com> (raw)
In-Reply-To: <523C9DE4.6040109-l0cyMroinI0@public.gmane.org>
On Saturday 21 September 2013 12:41 AM, Nishanth Menon wrote:
> On 09/20/2013 12:38 PM, Balaji T K wrote:
>> correct mux mode for mmc1_cmd to detect eMMC on bone-black
>>
>> Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>
>> ---
>> arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> index 56361ce..90ab56c 100644
>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> @@ -117,7 +117,7 @@
>> emmc_pins: pinmux_emmc_pins {
>> pinctrl-single,pins = <
>> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */
>> - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */
>> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */
>> 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */
>> 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */
>> 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
>>
> is'nt this a common change? why is it "black only"? if it is so, then
> the pinmux should probably be spun off outside bone-common.dtsi into
> boneblack.dtsi perhaps?
>
It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux can
remain in bone-common.dtsi.
However I could test only on beagle bone black which has eMMC on board, since I
don't have access to eMMC-cape
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: balajitk@ti.com (Balaji T K)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
Date: Mon, 23 Sep 2013 20:58:48 +0530 [thread overview]
Message-ID: <52405E30.2020001@ti.com> (raw)
In-Reply-To: <523C9DE4.6040109@ti.com>
On Saturday 21 September 2013 12:41 AM, Nishanth Menon wrote:
> On 09/20/2013 12:38 PM, Balaji T K wrote:
>> correct mux mode for mmc1_cmd to detect eMMC on bone-black
>>
>> Signed-off-by: Balaji T K <balajitk@ti.com>
>> ---
>> arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> index 56361ce..90ab56c 100644
>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> @@ -117,7 +117,7 @@
>> emmc_pins: pinmux_emmc_pins {
>> pinctrl-single,pins = <
>> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */
>> - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */
>> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */
>> 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */
>> 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */
>> 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
>>
> is'nt this a common change? why is it "black only"? if it is so, then
> the pinmux should probably be spun off outside bone-common.dtsi into
> boneblack.dtsi perhaps?
>
It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux can
remain in bone-common.dtsi.
However I could test only on beagle bone black which has eMMC on board, since I
don't have access to eMMC-cape
next prev parent reply other threads:[~2013-09-23 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 17:38 [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd Balaji T K
2013-09-20 17:38 ` Balaji T K
[not found] ` <1379698696-21945-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org>
2013-09-20 17:44 ` Felipe Balbi
2013-09-20 17:44 ` Felipe Balbi
2013-09-20 19:11 ` Nishanth Menon
2013-09-20 19:11 ` Nishanth Menon
[not found] ` <523C9DE4.6040109-l0cyMroinI0@public.gmane.org>
2013-09-23 15:28 ` Balaji T K [this message]
2013-09-23 15:28 ` Balaji T K
[not found] ` <52405E30.2020001-l0cyMroinI0@public.gmane.org>
2013-09-24 2:24 ` Nishanth Menon
2013-09-24 2:24 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52405E30.2020001@ti.com \
--to=balajitk-l0cymroini0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.