Re: [meta-selinux] Add sysvinit to DISTRO_FEATURES in oe-selinux distro.

[Philip Tricca <flihp@twobit.us>]

On 09/23/2013 10:36 AM, Philip Tricca wrote:
> On 09/23/2013 04:51 AM, Burton, Ross wrote:
>> On 23 September 2013 05:24, Philip Tricca <flihp@twobit.us> wrote:
>>> -DISTRO_FEATURES_append = "pam selinux"
>>> +DISTRO_FEATURES_append = "pam selinux sysvinit"
>>
>> sysvinit is a backfilled distro feature so you shouldn't need this.  I
>> can see two cases where you may need it: either you're setting
>> DISTRO_FEATURES_BACKFILL_CONSIDERED to sysvinit (in which case don't),
> 
> I'm not even sure what DISTRO_FEATURES_BACKFILL_CONSIDERED is so we can
> rule that out. Finding it in the docs now ...
> 
>> or you're cherry-picking pieces from different releases (in which case
>> this probably isn't the fix you're after).
> 
> I'm not doing anything so sophisticated (misguided?). I ran into this
> while setting up a build to test unrelated patches. Regardless this is
> the type of feedback I need so thank you. I'll go back and pull fresh
> from upstream and re-test.

I've located the source of this issue. Turns out DISTRO_FEATURES_BACKFILL
and DISTRO_FEATURES are concatenated somewhere along the way. The lack of
leading whitespace in the DISTRO_FEATURES_append from the oe-selinux distro
was causing 'sysvinit' and 'pam' to be combined into 'sysvinitpam'. The
check in the packagegroup class that I was running into must be evaluated
before any sanity check for invalid entries DISTRO_FEATURES.

Adding a leading space to the DISTRO_FEATURES_append in the oe-selinux
distro resolves this issue. Thanks for the pointer to the backfill
mechanism Ross. I'll submit a new patch.

Cheers,
- Philip