* [meta-selinux] Add sysvinit to DISTRO_FEATURES in oe-selinux distro.
@ 2013-09-23 4:24 Philip Tricca
2013-09-23 8:51 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: Philip Tricca @ 2013-09-23 4:24 UTC (permalink / raw)
To: yocto
The oe-selinux distro won't build against the master branch of
oe-core unless sysvinit is in DISTRO_FEATURES.
Commit c72ec4b52827f75351790eab483d258b2e87611a in oe-core adds a
sanity check to the packagegroup class that requires the
VIRTUAL-RUNTIME_init_manager explicitly be set in DISTRO_FEATURES.
Signed-off-by: Philip Tricca <flihp@twobit.us>
---
conf/distro/oe-selinux.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conf/distro/oe-selinux.conf b/conf/distro/oe-selinux.conf
index 9523abf..061529c 100644
--- a/conf/distro/oe-selinux.conf
+++ b/conf/distro/oe-selinux.conf
@@ -1,4 +1,4 @@
DISTRO = "oe-selinux"
DISTROOVERRIDES .= ":selinux"
-DISTRO_FEATURES_append = "pam selinux"
+DISTRO_FEATURES_append = "pam selinux sysvinit"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-selinux] Add sysvinit to DISTRO_FEATURES in oe-selinux distro.
2013-09-23 4:24 [meta-selinux] Add sysvinit to DISTRO_FEATURES in oe-selinux distro Philip Tricca
@ 2013-09-23 8:51 ` Burton, Ross
2013-09-23 14:36 ` Philip Tricca
0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2013-09-23 8:51 UTC (permalink / raw)
To: Philip Tricca; +Cc: yocto@yoctoproject.org
On 23 September 2013 05:24, Philip Tricca <flihp@twobit.us> wrote:
> -DISTRO_FEATURES_append = "pam selinux"
> +DISTRO_FEATURES_append = "pam selinux sysvinit"
sysvinit is a backfilled distro feature so you shouldn't need this. I
can see two cases where you may need it: either you're setting
DISTRO_FEATURES_BACKFILL_CONSIDERED to sysvinit (in which case don't),
or you're cherry-picking pieces from different releases (in which case
this probably isn't the fix you're after).
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-selinux] Add sysvinit to DISTRO_FEATURES in oe-selinux distro.
2013-09-23 8:51 ` Burton, Ross
@ 2013-09-23 14:36 ` Philip Tricca
2013-09-23 17:40 ` Philip Tricca
0 siblings, 1 reply; 4+ messages in thread
From: Philip Tricca @ 2013-09-23 14:36 UTC (permalink / raw)
To: Burton, Ross; +Cc: yocto@yoctoproject.org
On 09/23/2013 04:51 AM, Burton, Ross wrote:
> On 23 September 2013 05:24, Philip Tricca <flihp@twobit.us> wrote:
>> -DISTRO_FEATURES_append = "pam selinux"
>> +DISTRO_FEATURES_append = "pam selinux sysvinit"
>
> sysvinit is a backfilled distro feature so you shouldn't need this. I
> can see two cases where you may need it: either you're setting
> DISTRO_FEATURES_BACKFILL_CONSIDERED to sysvinit (in which case don't),
I'm not even sure what DISTRO_FEATURES_BACKFILL_CONSIDERED is so we can
rule that out. Finding it in the docs now ...
> or you're cherry-picking pieces from different releases (in which case
> this probably isn't the fix you're after).
I'm not doing anything so sophisticated (misguided?). I ran into this
while setting up a build to test unrelated patches. Regardless this is
the type of feedback I need so thank you. I'll go back and pull fresh
from upstream and re-test.
Regards,
- Philip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-selinux] Add sysvinit to DISTRO_FEATURES in oe-selinux distro.
2013-09-23 14:36 ` Philip Tricca
@ 2013-09-23 17:40 ` Philip Tricca
0 siblings, 0 replies; 4+ messages in thread
From: Philip Tricca @ 2013-09-23 17:40 UTC (permalink / raw)
To: Burton, Ross; +Cc: yocto@yoctoproject.org
On 09/23/2013 10:36 AM, Philip Tricca wrote:
> On 09/23/2013 04:51 AM, Burton, Ross wrote:
>> On 23 September 2013 05:24, Philip Tricca <flihp@twobit.us> wrote:
>>> -DISTRO_FEATURES_append = "pam selinux"
>>> +DISTRO_FEATURES_append = "pam selinux sysvinit"
>>
>> sysvinit is a backfilled distro feature so you shouldn't need this. I
>> can see two cases where you may need it: either you're setting
>> DISTRO_FEATURES_BACKFILL_CONSIDERED to sysvinit (in which case don't),
>
> I'm not even sure what DISTRO_FEATURES_BACKFILL_CONSIDERED is so we can
> rule that out. Finding it in the docs now ...
>
>> or you're cherry-picking pieces from different releases (in which case
>> this probably isn't the fix you're after).
>
> I'm not doing anything so sophisticated (misguided?). I ran into this
> while setting up a build to test unrelated patches. Regardless this is
> the type of feedback I need so thank you. I'll go back and pull fresh
> from upstream and re-test.
I've located the source of this issue. Turns out DISTRO_FEATURES_BACKFILL
and DISTRO_FEATURES are concatenated somewhere along the way. The lack of
leading whitespace in the DISTRO_FEATURES_append from the oe-selinux distro
was causing 'sysvinit' and 'pam' to be combined into 'sysvinitpam'. The
check in the packagegroup class that I was running into must be evaluated
before any sanity check for invalid entries DISTRO_FEATURES.
Adding a leading space to the DISTRO_FEATURES_append in the oe-selinux
distro resolves this issue. Thanks for the pointer to the backfill
mechanism Ross. I'll submit a new patch.
Cheers,
- Philip
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-23 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 4:24 [meta-selinux] Add sysvinit to DISTRO_FEATURES in oe-selinux distro Philip Tricca
2013-09-23 8:51 ` Burton, Ross
2013-09-23 14:36 ` Philip Tricca
2013-09-23 17:40 ` Philip Tricca
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.