From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org
Cc: "Ivan T. Ivanov"
<iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
idos-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information
Date: Mon, 23 Sep 2013 16:03:18 -0600 [thread overview]
Message-ID: <5240BAA6.9090509@wwwdotorg.org> (raw)
In-Reply-To: <20130923193224.GO30811@radagast>
On 09/23/2013 01:32 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote:
>> From: "Ivan T. Ivanov" <iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
>>
>> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS)
>> and HS, SS PHY's control and configuration registers.
>>
>> It could operate in device mode (SS, HS, FS) and host mode (SS,
>> HS, FS, LS).
>>
>> Signed-off-by: Ivan T. Ivanov <iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
>
> and here's a new version from same patch
The binding looks pretty simple, so I don't think it's too contentious.
>> diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt
>> b/Documentation/devicetree/bindings/usb/msm-ssusb.txt
>> +MSM DWC3 controller wrapper
>> +Optional properties : +- gdsc-supply : phandle to the globally
>> distributed switch controller + regulator node to the USB
>> controller.
If that's a regulator node, why not use xxx-supply properties to
interface with it?
Aside from that, the binding,
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: balbi@ti.com
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ian.campbell@citrix.com, rob@landley.net,
gregkh@linuxfoundation.org, grant.likely@linaro.org,
idos@codeaurora.org, mgautam@codeaurora.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information
Date: Mon, 23 Sep 2013 16:03:18 -0600 [thread overview]
Message-ID: <5240BAA6.9090509@wwwdotorg.org> (raw)
In-Reply-To: <20130923193224.GO30811@radagast>
On 09/23/2013 01:32 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote:
>> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>>
>> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS)
>> and HS, SS PHY's control and configuration registers.
>>
>> It could operate in device mode (SS, HS, FS) and host mode (SS,
>> HS, FS, LS).
>>
>> Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
>
> and here's a new version from same patch
The binding looks pretty simple, so I don't think it's too contentious.
>> diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt
>> b/Documentation/devicetree/bindings/usb/msm-ssusb.txt
>> +MSM DWC3 controller wrapper
>> +Optional properties : +- gdsc-supply : phandle to the globally
>> distributed switch controller + regulator node to the USB
>> controller.
If that's a regulator node, why not use xxx-supply properties to
interface with it?
Aside from that, the binding,
Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2013-09-23 22:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 13:29 [PATCH v5 0/3] DWC3 USB support for Qualcomm platform Ivan T. Ivanov
2013-08-21 13:29 ` [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information Ivan T. Ivanov
2013-09-23 19:32 ` Felipe Balbi
2013-09-23 19:32 ` Felipe Balbi
2013-09-23 22:03 ` Stephen Warren [this message]
2013-09-23 22:03 ` Stephen Warren
2013-10-01 12:05 ` Ivan T. Ivanov
2013-10-01 12:08 ` Ivan T. Ivanov
2013-10-04 14:31 ` Felipe Balbi
2013-10-04 14:31 ` Felipe Balbi
2013-10-07 7:57 ` Ivan T. Ivanov
[not found] ` <1377091786-5613-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-08-21 13:29 ` [PATCH v5 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's Ivan T. Ivanov
2013-08-21 13:29 ` Ivan T. Ivanov
2013-09-23 19:32 ` Felipe Balbi
2013-09-23 19:32 ` Felipe Balbi
2013-08-21 13:29 ` [PATCH v5 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5240BAA6.9090509@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=idos-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.