From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
Cc: rjw@sisk.pl, kgene.kim@samsung.com, viresh.kumar@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
kyungmin.park@samsung.com, ben-linux@fluff.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rob.herring@calxeda.com,
pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, rob@landley.net,
mturquette@linaro.org, tomasz.figa@gmail.com,
thomas.abraham@linaro.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, t.stanislaws@samsung.com,
m.szyprowski@samsung.com, b.zolnierkie@samsung.com
Subject: Re: [PATCH v5 1/3] clk: samsung: Add clock driver for s5pc110/s5pv210
Date: Tue, 24 Sep 2013 15:58:06 +0200 [thread overview]
Message-ID: <52419A6E.9020203@samsung.com> (raw)
In-Reply-To: <1380027009-2239-2-git-send-email-m.krawczuk@partner.samsung.com>
Hi,
On 24/09/13 14:50, Mateusz Krawczuk wrote:
> +++ b/Documentation/devicetree/bindings/clock/samsung,s5pv210-clock.txt
> @@ -0,0 +1,75 @@
> +* Samsung S5PC110/S5PV210 Clock Controller
> +
> +The S5PV210 clock controller generates and supplies clock to various controllers
> +within the SoC. The clock binding described here is applicable to all SoCs in
> +the S5PC110/S5PV210 family.
> +
> +Required Properties:
> +
> +- compatible: should be "samsung,s5pv210-clock".
I have nothing against this compatible value, but wouldn't it be more
accurate to use, e.g. "samsung,s5pv210-cmu" - for Clock Management Unit,
as this IP block is also referred to in the documentation ?
May just be me, but "samsung,s5pv210-clock" sounds like just one
specific clock type.
--
Thanks,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] clk: samsung: Add clock driver for s5pc110/s5pv210
Date: Tue, 24 Sep 2013 15:58:06 +0200 [thread overview]
Message-ID: <52419A6E.9020203@samsung.com> (raw)
In-Reply-To: <1380027009-2239-2-git-send-email-m.krawczuk@partner.samsung.com>
Hi,
On 24/09/13 14:50, Mateusz Krawczuk wrote:
> +++ b/Documentation/devicetree/bindings/clock/samsung,s5pv210-clock.txt
> @@ -0,0 +1,75 @@
> +* Samsung S5PC110/S5PV210 Clock Controller
> +
> +The S5PV210 clock controller generates and supplies clock to various controllers
> +within the SoC. The clock binding described here is applicable to all SoCs in
> +the S5PC110/S5PV210 family.
> +
> +Required Properties:
> +
> +- compatible: should be "samsung,s5pv210-clock".
I have nothing against this compatible value, but wouldn't it be more
accurate to use, e.g. "samsung,s5pv210-cmu" - for Clock Management Unit,
as this IP block is also referred to in the documentation ?
May just be me, but "samsung,s5pv210-clock" sounds like just one
specific clock type.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2013-09-24 13:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 12:50 [PATCH v5 0/3] ARM: S5PV210: move to common clk framework Mateusz Krawczuk
2013-09-24 12:50 ` Mateusz Krawczuk
2013-09-24 12:50 ` [PATCH v5 1/3] clk: samsung: Add clock driver for s5pc110/s5pv210 Mateusz Krawczuk
2013-09-24 12:50 ` Mateusz Krawczuk
2013-09-24 13:58 ` Sylwester Nawrocki [this message]
2013-09-24 13:58 ` Sylwester Nawrocki
[not found] ` <52419A6E.9020203-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-24 14:26 ` Tomasz Figa
2013-09-24 14:26 ` Tomasz Figa
2013-09-24 14:26 ` Tomasz Figa
2013-09-24 12:50 ` [PATCH v5 2/3] Cpufreq: s5pv210 cpufreq fixes for CCF Mateusz Krawczuk
2013-09-24 12:50 ` Mateusz Krawczuk
2013-09-24 12:50 ` [PATCH v5 3/3] ARM: s5pv210: Migrate clock handling to Common Clock Framework Mateusz Krawczuk
2013-09-24 12:50 ` Mateusz Krawczuk
2013-09-24 13:04 ` [PATCH v5 0/3] ARM: S5PV210: move to common clk framework Tomasz Figa
2013-09-24 13:04 ` Tomasz Figa
2013-10-19 16:03 ` Tomasz Figa
2013-10-19 16:03 ` Tomasz Figa
2013-10-20 20:51 ` Kukjin Kim
2013-10-20 20:51 ` Kukjin Kim
2013-10-21 12:16 ` Mike Turquette
2013-10-21 12:16 ` Mike Turquette
2013-10-21 12:16 ` Mike Turquette
2013-10-29 11:42 ` Tomasz Figa
2013-10-29 11:42 ` Tomasz Figa
2013-10-29 15:46 ` Kukjin Kim
2013-10-29 15:46 ` Kukjin Kim
2013-10-29 17:46 ` Mike Turquette
2013-10-29 17:46 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52419A6E.9020203@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=cpufreq@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.krawczuk@partner.samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=rjw@sisk.pl \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=t.stanislaws@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.