From: Thomas Hellstrom <thellstrom@vmware.com>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Dave Airlie <airlied@linux.ie>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ben Skeggs <bskeggs@redhat.com>,
Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [RFC PATCH] drm/nouveau: fix nested locking in mmap handler
Date: Tue, 24 Sep 2013 19:04:11 +0200 [thread overview]
Message-ID: <5241C60B.9070706@vmware.com> (raw)
In-Reply-To: <52417866.5090609@canonical.com>
On 09/24/2013 01:32 PM, Maarten Lankhorst wrote:
> Op 24-09-13 12:33, Thomas Hellstrom schreef:
>> On 09/24/2013 12:11 PM, Maarten Lankhorst wrote:
>>>
>>> It seems userspace only updates offset and domain in nouveau. If it fails to update
>>> it would result in the same affect as when the buffer gets moved around by TTM.
>>> But hey maybe I'll have some fun, I'll lie to userspace, hardcode userspace offset
>>> to 0x40000000, always force domain to be different and see what breaks.
>>>
>>> My guess is absolutely nothing, except it might expose some bugs where we forgot annotation..
>> I think that would certainly break if your return an -ERESTARTSYS after applying relocations but
>> before submitting the command stream to hardware....
> The relocations are updated before submitting the command stream, but it's copied back to userspace
> after submitting the command stream. I'm not sure what -ERESTARTSYS would change, the syscall
> is not in an interruptible state.
Hmm, I was assuming without looking at the code that there was an
interruptible wait for pipe/ring space after
relocation application.
/Thomas
next prev parent reply other threads:[~2013-09-24 17:04 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 15:06 [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE Peter Zijlstra
2013-09-12 15:11 ` Maarten Lankhorst
2013-09-12 15:14 ` Peter Zijlstra
2013-09-12 15:14 ` Peter Zijlstra
2013-09-12 15:36 ` Daniel Vetter
2013-09-12 15:43 ` Peter Zijlstra
2013-09-12 15:43 ` Peter Zijlstra
2013-09-12 15:58 ` Daniel Vetter
2013-09-12 16:22 ` Peter Zijlstra
2013-09-12 16:35 ` Chris Wilson
2013-09-12 16:35 ` Chris Wilson
2013-09-12 20:30 ` Peter Zijlstra
2013-09-12 20:37 ` Thomas Gleixner
2013-09-12 19:52 ` Daniel Vetter
2013-09-12 19:58 ` Thomas Gleixner
2013-09-12 20:04 ` Daniel Vetter
2013-09-12 20:20 ` Thomas Gleixner
2013-09-12 20:23 ` Daniel Vetter
2013-09-12 20:39 ` Thomas Gleixner
2013-09-12 20:48 ` Thomas Hellstrom
2013-09-12 20:48 ` Thomas Hellstrom
2013-09-12 16:33 ` Thomas Hellstrom
2013-09-12 16:33 ` Thomas Hellstrom
2013-09-12 15:45 ` Maarten Lankhorst
2013-09-12 15:45 ` Maarten Lankhorst
2013-09-12 16:44 ` Thomas Hellstrom
2013-09-12 19:48 ` Daniel Vetter
2013-09-12 21:50 ` Maarten Lankhorst
2013-09-13 5:33 ` Thomas Hellstrom
2013-09-13 8:26 ` Daniel Vetter
2013-10-08 14:14 ` [RFC PATCH] drm/radeon: fixup locking inversion between mmap_sem and reservations Maarten Lankhorst
2013-10-08 14:33 ` Jerome Glisse
2013-10-08 14:45 ` Christian König
2013-10-08 14:55 ` Jerome Glisse
2013-10-08 16:29 ` Thomas Hellstrom
2013-10-08 16:47 ` Jerome Glisse
2013-10-08 16:58 ` Thomas Hellstrom
2013-10-09 12:36 ` [RFC PATCH v2] drm/radeon: fixup locking inversion between, " Maarten Lankhorst
2013-10-09 10:58 ` [RFC PATCH] drm/radeon: fixup locking inversion between " Maarten Lankhorst
2013-10-08 14:45 ` Maarten Lankhorst
2013-10-08 14:57 ` Jerome Glisse
2013-09-13 6:44 ` [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE Thomas Hellstrom
2013-09-13 6:44 ` Thomas Hellstrom
2013-09-13 7:16 ` Maarten Lankhorst
2013-09-13 7:46 ` Thomas Hellstrom
2013-09-13 7:51 ` Maarten Lankhorst
2013-09-13 8:23 ` Thomas Hellstrom
2013-09-13 8:23 ` Thomas Hellstrom
2013-09-13 8:32 ` Daniel Vetter
2013-09-13 8:39 ` Thomas Hellstrom
2013-09-13 8:58 ` Maarten Lankhorst
2013-09-13 9:21 ` Thomas Hellstrom
2013-09-13 8:29 ` Peter Zijlstra
2013-09-13 8:41 ` Daniel Vetter
2013-09-13 9:00 ` Peter Zijlstra
2013-09-23 15:33 ` [RFC PATCH] drm/nouveau: fix nested locking in mmap handler Maarten Lankhorst
2013-09-24 7:22 ` Thomas Hellstrom
2013-09-24 7:34 ` Maarten Lankhorst
2013-09-24 8:20 ` Ingo Molnar
2013-09-24 9:03 ` Thomas Hellstrom
2013-09-24 9:36 ` Daniel Vetter
2013-09-24 10:11 ` Maarten Lankhorst
2013-09-24 10:33 ` Thomas Hellstrom
2013-09-24 11:32 ` Maarten Lankhorst
2013-09-24 17:04 ` Thomas Hellstrom [this message]
2013-09-24 9:43 ` Maarten Lankhorst
2013-09-24 9:43 ` Maarten Lankhorst
2013-09-24 17:53 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241C60B.9070706@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.