[PATCH] of: introduce of_get_available_child_count

[PATCH] of: introduce of_get_available_child_count

[Bryan Wu]

Some drivers keep counting available child by themselves. So
introduce a new simple API like of_get_child_count() but for
available childs.

Cc: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 include/linux/of.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index f95aee3..54c2560 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -226,6 +226,17 @@ static inline int of_get_child_count(const struct device_node *np)
 	return num;
 }
 
+static inline int of_get_available_child_count(const struct device_node *np)
+{
+	struct device_node *child;
+	int num = 0;
+
+	for_each_available_child_of_node(np, child)
+		num++;
+
+	return num;
+}
+
 extern struct device_node *of_find_node_with_property(
 	struct device_node *from, const char *prop_name);
 #define for_each_node_with_property(dn, prop_name) \
@@ -376,6 +387,11 @@ static inline int of_get_child_count(const struct device_node *np)
 	return 0;
 }
 
+static inline int of_get_available_child_count(const struct device_node *np)
+{
+	return 0;
+}
+
 static inline int of_device_is_compatible(const struct device_node *device,
 					  const char *name)
 {
-- 
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: introduce of_get_available_child_count

[Rob Herring]

On 09/24/2013 12:50 PM, Bryan Wu wrote:
> Some drivers keep counting available child by themselves. So
> introduce a new simple API like of_get_child_count() but for
> available childs.
> 
> Cc: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---

Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>

I assume you have some user and will take this dependency thru that tree?

>  include/linux/of.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index f95aee3..54c2560 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -226,6 +226,17 @@ static inline int of_get_child_count(const struct device_node *np)
>  	return num;
>  }
>  
> +static inline int of_get_available_child_count(const struct device_node *np)
> +{
> +	struct device_node *child;
> +	int num = 0;
> +
> +	for_each_available_child_of_node(np, child)
> +		num++;
> +
> +	return num;
> +}
> +
>  extern struct device_node *of_find_node_with_property(
>  	struct device_node *from, const char *prop_name);
>  #define for_each_node_with_property(dn, prop_name) \
> @@ -376,6 +387,11 @@ static inline int of_get_child_count(const struct device_node *np)
>  	return 0;
>  }
>  
> +static inline int of_get_available_child_count(const struct device_node *np)
> +{
> +	return 0;
> +}
> +
>  static inline int of_device_is_compatible(const struct device_node *device,
>  					  const char *name)
>  {
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: introduce of_get_available_child_count

[Bryan Wu]

On Tue, Sep 24, 2013 at 2:16 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 09/24/2013 12:50 PM, Bryan Wu wrote:
>> Some drivers keep counting available child by themselves. So
>> introduce a new simple API like of_get_child_count() but for
>> available childs.
>>
>> Cc: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>> Signed-off-by: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>
> Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>
> I assume you have some user and will take this dependency thru that tree?
>

Exactly, a patch from Josh [1] inspired me to create this API.

Thanks,
-Bryan

[1]: https://lkml.org/lkml/2013/9/24/68


>>  include/linux/of.h | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index f95aee3..54c2560 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -226,6 +226,17 @@ static inline int of_get_child_count(const struct device_node *np)
>>       return num;
>>  }
>>
>> +static inline int of_get_available_child_count(const struct device_node *np)
>> +{
>> +     struct device_node *child;
>> +     int num = 0;
>> +
>> +     for_each_available_child_of_node(np, child)
>> +             num++;
>> +
>> +     return num;
>> +}
>> +
>>  extern struct device_node *of_find_node_with_property(
>>       struct device_node *from, const char *prop_name);
>>  #define for_each_node_with_property(dn, prop_name) \
>> @@ -376,6 +387,11 @@ static inline int of_get_child_count(const struct device_node *np)
>>       return 0;
>>  }
>>
>> +static inline int of_get_available_child_count(const struct device_node *np)
>> +{
>> +     return 0;
>> +}
>> +
>>  static inline int of_device_is_compatible(const struct device_node *device,
>>                                         const char *name)
>>  {
>>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: introduce of_get_available_child_count

[Bryan Wu]

On Tue, Sep 24, 2013 at 2:22 PM, Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Sep 24, 2013 at 2:16 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 09/24/2013 12:50 PM, Bryan Wu wrote:
>>> Some drivers keep counting available child by themselves. So
>>> introduce a new simple API like of_get_child_count() but for
>>> available childs.
>>>
>>> Cc: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>>> Signed-off-by: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>
>> Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>>

Will this patch be merged through you guys or need I take care of it?

Thanks,
-Bryan

>> I assume you have some user and will take this dependency thru that tree?
>>
>
> Exactly, a patch from Josh [1] inspired me to create this API.
>
> Thanks,
> -Bryan
>
> [1]: https://lkml.org/lkml/2013/9/24/68
>
>
>>>  include/linux/of.h | 16 ++++++++++++++++
>>>  1 file changed, 16 insertions(+)
>>>
>>> diff --git a/include/linux/of.h b/include/linux/of.h
>>> index f95aee3..54c2560 100644
>>> --- a/include/linux/of.h
>>> +++ b/include/linux/of.h
>>> @@ -226,6 +226,17 @@ static inline int of_get_child_count(const struct device_node *np)
>>>       return num;
>>>  }
>>>
>>> +static inline int of_get_available_child_count(const struct device_node *np)
>>> +{
>>> +     struct device_node *child;
>>> +     int num = 0;
>>> +
>>> +     for_each_available_child_of_node(np, child)
>>> +             num++;
>>> +
>>> +     return num;
>>> +}
>>> +
>>>  extern struct device_node *of_find_node_with_property(
>>>       struct device_node *from, const char *prop_name);
>>>  #define for_each_node_with_property(dn, prop_name) \
>>> @@ -376,6 +387,11 @@ static inline int of_get_child_count(const struct device_node *np)
>>>       return 0;
>>>  }
>>>
>>> +static inline int of_get_available_child_count(const struct device_node *np)
>>> +{
>>> +     return 0;
>>> +}
>>> +
>>>  static inline int of_device_is_compatible(const struct device_node *device,
>>>                                         const char *name)
>>>  {
>>>
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: introduce of_get_available_child_count

[Grant Likely]

On Thu, 24 Oct 2013 11:09:54 -0700, Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Sep 24, 2013 at 2:22 PM, Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > On Tue, Sep 24, 2013 at 2:16 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >> On 09/24/2013 12:50 PM, Bryan Wu wrote:
> >>> Some drivers keep counting available child by themselves. So
> >>> introduce a new simple API like of_get_child_count() but for
> >>> available childs.
> >>>
> >>> Cc: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> >>> Signed-off-by: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>> ---
> >>
> >> Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> >>
> 
> Will this patch be merged through you guys or need I take care of it?

Merge it with the patch that needs it.

g.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: introduce of_get_available_child_count

[Bryan Wu]

On Thu, Oct 24, 2013 at 5:02 PM, Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Thu, 24 Oct 2013 11:09:54 -0700, Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Tue, Sep 24, 2013 at 2:22 PM, Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> > On Tue, Sep 24, 2013 at 2:16 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> >> On 09/24/2013 12:50 PM, Bryan Wu wrote:
>> >>> Some drivers keep counting available child by themselves. So
>> >>> introduce a new simple API like of_get_child_count() but for
>> >>> available childs.
>> >>>
>> >>> Cc: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>> >>> Signed-off-by: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >>> ---
>> >>
>> >> Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> >>
>>
>> Will this patch be merged through you guys or need I take care of it?
>
> Merge it with the patch that needs it.
>

OK, I will do that.
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html