From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 3/4] KVM: nVMX: Check all exceptions for intercept during delivery to L2
Date: Wed, 25 Sep 2013 16:22:48 +0200 [thread overview]
Message-ID: <5242F1B8.6040506@redhat.com> (raw)
In-Reply-To: <20130925141948.GC30317@redhat.com>
Il 25/09/2013 16:19, Gleb Natapov ha scritto:
>>> > > -static int nested_pf_handled(struct kvm_vcpu *vcpu)
>>> > > +static int nested_ex_handled(struct kvm_vcpu *vcpu, unsigned nr)
>>> > > {
>>> > > struct vmcs12 *vmcs12 = get_vmcs12(vcpu);
>>> > >
>>> > > - /* TODO: also check PFEC_MATCH/MASK, not just EB.PF. */
>> >
>> > Just one more question, why drop this comment? It doesn't seem
>> > incorrect in the particular case where nr == PF_VECTOR.
>
> I moved it to vmx_inject_page_fault_nested().
Ah, so if you test it there, you shouldn't get here unless the
PFEC_MASK/MATCH matches. In the case of EPT, you run with L1
PFEC_MASK/MATCH so you do not need any check.
Paolo
next prev parent reply other threads:[~2013-09-25 14:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 9:51 [PATCH 0/4] Fix shadow-on-shadow nested VMX Gleb Natapov
2013-09-25 9:51 ` [PATCH 1/4] KVM: nVMX: Amend nested_run_pending logic Gleb Natapov
2013-09-25 9:51 ` [PATCH 2/4] KVM: nVMX: Do not put exception that caused vmexit to IDT_VECTORING_INFO Gleb Natapov
2013-09-25 9:51 ` [PATCH 3/4] KVM: nVMX: Check all exceptions for intercept during delivery to L2 Gleb Natapov
2013-09-25 10:38 ` Paolo Bonzini
2013-09-25 11:00 ` Gleb Natapov
2013-09-25 11:25 ` Paolo Bonzini
2013-09-25 11:52 ` Gleb Natapov
2013-09-25 14:00 ` Paolo Bonzini
2013-09-25 14:19 ` Gleb Natapov
2013-09-25 14:22 ` Paolo Bonzini [this message]
2013-09-25 16:31 ` Gleb Natapov
2013-09-25 9:51 ` [PATCH 4/4] KVM: nVMX: Do not generate #DF if #PF happens during exception delivery into L2 Gleb Natapov
2013-09-25 11:24 ` Paolo Bonzini
2013-09-25 11:51 ` Gleb Natapov
2013-09-25 12:08 ` Paolo Bonzini
2013-09-25 12:21 ` Gleb Natapov
2013-09-25 13:26 ` Paolo Bonzini
2013-09-25 13:36 ` Gleb Natapov
2013-09-25 13:53 ` Paolo Bonzini
2013-09-26 15:10 ` [PATCH 0/4] Fix shadow-on-shadow nested VMX Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5242F1B8.6040506@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.