* [PATCH 1/4] video: vfb: Remove incorrect check
@ 2013-09-25 12:14 Sachin Kamat
2013-09-26 9:10 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-09-25 12:14 UTC (permalink / raw)
To: linux-fbdev
'yoffset' is unsigned and hence cannot be less than 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/vfb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
index ee5985e..ea2b523 100644
--- a/drivers/video/vfb.c
+++ b/drivers/video/vfb.c
@@ -390,9 +390,8 @@ static int vfb_pan_display(struct fb_var_screeninfo *var,
struct fb_info *info)
{
if (var->vmode & FB_VMODE_YWRAP) {
- if (var->yoffset < 0
- || var->yoffset >= info->var.yres_virtual
- || var->xoffset)
+ if (var->yoffset >= info->var.yres_virtual ||
+ var->xoffset)
return -EINVAL;
} else {
if (var->xoffset + info->var.xres > info->var.xres_virtual ||
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/4] video: vfb: Remove incorrect check
2013-09-25 12:14 [PATCH 1/4] video: vfb: Remove incorrect check Sachin Kamat
@ 2013-09-26 9:10 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2013-09-26 9:10 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 25/09/13 15:02, Sachin Kamat wrote:
> 'yoffset' is unsigned and hence cannot be less than 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/vfb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
> index ee5985e..ea2b523 100644
> --- a/drivers/video/vfb.c
> +++ b/drivers/video/vfb.c
> @@ -390,9 +390,8 @@ static int vfb_pan_display(struct fb_var_screeninfo *var,
> struct fb_info *info)
> {
> if (var->vmode & FB_VMODE_YWRAP) {
> - if (var->yoffset < 0
> - || var->yoffset >= info->var.yres_virtual
> - || var->xoffset)
> + if (var->yoffset >= info->var.yres_virtual ||
> + var->xoffset)
> return -EINVAL;
> } else {
> if (var->xoffset + info->var.xres > info->var.xres_virtual ||
>
Thanks, queueng the series for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-26 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 12:14 [PATCH 1/4] video: vfb: Remove incorrect check Sachin Kamat
2013-09-26 9:10 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.