From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
Date: Thu, 26 Sep 2013 10:21:31 +0000 [thread overview]
Message-ID: <52440AAB.70101@ti.com> (raw)
In-Reply-To: <20130926101247.GB19304@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 26/09/13 13:12, Mark Brown wrote:
> On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote:
>
>> I wish we could "select" instead of "depends on"...
>
> We probably could.
I'm not so sure.
If we select BACKLIGHT_CLASS_DEVICE, we could end up compiling
backlight.c without fbdev, and backlight.c uses fb's funcs.
The funny thing is, there is FB_BACKLIGHT, which seems to be designed to
be selectable (and is selected). That one depends on FB, but if I'm not
mistaken, that dependency does not do anything if FB_BACKLIGHT is selected.
FB_BACKLIGHT in turn selects both BACKLIGHT_LCD_SUPPORT and
BACKLIGHT_CLASS_DEVICE, neither of which seem to be designed to be
selectable.
I think that's a bit broken. Anyway, I guess it's better to "depend on"
here, to be on the safe side.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
Date: Thu, 26 Sep 2013 13:21:31 +0300 [thread overview]
Message-ID: <52440AAB.70101@ti.com> (raw)
In-Reply-To: <20130926101247.GB19304@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 26/09/13 13:12, Mark Brown wrote:
> On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote:
>
>> I wish we could "select" instead of "depends on"...
>
> We probably could.
I'm not so sure.
If we select BACKLIGHT_CLASS_DEVICE, we could end up compiling
backlight.c without fbdev, and backlight.c uses fb's funcs.
The funny thing is, there is FB_BACKLIGHT, which seems to be designed to
be selectable (and is selected). That one depends on FB, but if I'm not
mistaken, that dependency does not do anything if FB_BACKLIGHT is selected.
FB_BACKLIGHT in turn selects both BACKLIGHT_LCD_SUPPORT and
BACKLIGHT_CLASS_DEVICE, neither of which seem to be designed to be
selectable.
I think that's a bit broken. Anyway, I guess it's better to "depend on"
here, to be on the safe side.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-09-26 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 11:31 [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier Mark Brown
2013-09-25 11:31 ` Mark Brown
2013-09-26 0:59 ` Jingoo Han
2013-09-26 0:59 ` Jingoo Han
2013-09-26 8:36 ` Tomi Valkeinen
2013-09-26 8:36 ` Tomi Valkeinen
2013-09-26 10:12 ` Mark Brown
2013-09-26 10:12 ` Mark Brown
2013-09-26 10:21 ` Tomi Valkeinen [this message]
2013-09-26 10:21 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52440AAB.70101@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=broonie@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.