From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: i2c-dev: Create 'name' attribute automatically
Date: Thu, 26 Sep 2013 03:37:08 -0700 [thread overview]
Message-ID: <52440E54.5080401@roeck-us.net> (raw)
In-Reply-To: <20130926082835.GA3057@katana>
On 09/26/2013 01:28 AM, Wolfram Sang wrote:
> Hi,
>
>>> What race condition?
>>>
>>
>> Userspace trying to access the name attribute before it is created.
>> See http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/
>
> Thanks!
>
>>> Have you tried this with two instances? I don't think it will work since
>>> class_register modifies the class struct.
>>>
>> Half a dozen instances, actually. Unless I am missing something, seems to be
>
> My bad. Sorry for the noise.
>
>> Anyway, the patch is obsolete; one is supposed to use class->dev_groups now.
>
> Are you willing to update the patch?
>
Sure. Give me a couple of days.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: i2c-dev: Create 'name' attribute automatically
Date: Thu, 26 Sep 2013 03:37:08 -0700 [thread overview]
Message-ID: <52440E54.5080401@roeck-us.net> (raw)
In-Reply-To: <20130926082835.GA3057@katana>
On 09/26/2013 01:28 AM, Wolfram Sang wrote:
> Hi,
>
>>> What race condition?
>>>
>>
>> Userspace trying to access the name attribute before it is created.
>> See http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/
>
> Thanks!
>
>>> Have you tried this with two instances? I don't think it will work since
>>> class_register modifies the class struct.
>>>
>> Half a dozen instances, actually. Unless I am missing something, seems to be
>
> My bad. Sorry for the noise.
>
>> Anyway, the patch is obsolete; one is supposed to use class->dev_groups now.
>
> Are you willing to update the patch?
>
Sure. Give me a couple of days.
Thanks,
Guenter
next prev parent reply other threads:[~2013-09-26 10:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 16:30 [PATCH] i2c: i2c-dev: Create 'name' attribute automatically Guenter Roeck
2013-08-31 16:30 ` Guenter Roeck
[not found] ` <1377966619-20197-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-09-25 20:20 ` Wolfram Sang
2013-09-25 20:20 ` Wolfram Sang
2013-09-25 21:11 ` Guenter Roeck
2013-09-25 21:11 ` Guenter Roeck
2013-09-26 8:28 ` Wolfram Sang
2013-09-26 10:37 ` Guenter Roeck [this message]
2013-09-26 10:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52440E54.5080401@roeck-us.net \
--to=linux-0h96xk9xttrk1umjsbkqmq@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.