From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Julien Grall <julien.grall@linaro.org>,
xen-devel@lists.xen.org, patches@linaro.org,
andre.przywara@linaro.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 2/4] xen/arm: Add macro ALIGN
Date: Thu, 26 Sep 2013 15:34:00 +0100 [thread overview]
Message-ID: <524445D8.9040509@citrix.com> (raw)
In-Reply-To: <1380205857.29483.101.camel@kazak.uk.xensource.com>
On 26/09/13 15:30, Ian Campbell wrote:
> On Thu, 2013-09-26 at 13:56 +0100, Julien Grall wrote:
>
>> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
>> index 2cea1ba..35f3b29 100644
>> --- a/xen/include/asm-arm/config.h
>> +++ b/xen/include/asm-arm/config.h
>> @@ -186,6 +186,10 @@
>> #define STACK_SIZE (PAGE_SIZE << STACK_ORDER)
>>
>> #ifndef __ASSEMBLY__
>> +#define ALIGN(x, a) (((x) + (a) - 1) & ~((a) - 1))
> Seems like there ought to be a place under include/xen where this would
> fit.
>
> xen/include/xen/lib.h I reckon.
Except x86 has #define ALIGN _ALIGN which will surely cause problems?
~Andrew
next prev parent reply other threads:[~2013-09-26 14:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 12:56 [PATCH v2 0/4] ARM: Support initrd loading Julien Grall
2013-09-26 12:56 ` [PATCH v2 1/4] xen/arm: Add macro MB Julien Grall
2013-09-26 14:32 ` Ian Campbell
2013-09-26 15:26 ` Julien Grall
2013-09-26 15:30 ` Ian Campbell
2013-09-26 15:32 ` Julien Grall
2013-09-26 15:52 ` Ian Campbell
2013-09-26 12:56 ` [PATCH v2 2/4] xen/arm: Add macro ALIGN Julien Grall
2013-09-26 14:30 ` Ian Campbell
2013-09-26 14:34 ` Andrew Cooper [this message]
2013-09-26 14:38 ` Ian Campbell
2013-09-26 14:41 ` Andrew Cooper
2013-09-26 15:26 ` Julien Grall
2013-09-26 12:56 ` [PATCH v2 3/4] xen/arm: Add support to load initrd in dom0 Julien Grall
2013-09-26 14:34 ` Ian Campbell
2013-09-26 12:56 ` [PATCH v2 4/4] xen/dts: Support Linux initrd DT bindings Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524445D8.9040509@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=andre.przywara@linaro.org \
--cc=julien.grall@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.