From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, andre.przywara@linaro.org,
patches@linaro.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 1/4] xen/arm: Add macro MB
Date: Thu, 26 Sep 2013 16:26:11 +0100 [thread overview]
Message-ID: <52445213.6010905@linaro.org> (raw)
In-Reply-To: <1380205963.29483.103.camel@kazak.uk.xensource.com>
On 09/26/2013 03:32 PM, Ian Campbell wrote:
> On Thu, 2013-09-26 at 13:56 +0100, Julien Grall wrote:
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> ---
>> xen/include/asm-arm/config.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
>> index 604088e..2cea1ba 100644
>> --- a/xen/include/asm-arm/config.h
>> +++ b/xen/include/asm-arm/config.h
>> @@ -119,6 +119,7 @@
>> #define BOOT_MISC_VIRT_START _AT(vaddr_t,0x00600000)
>>
>> #define HYPERVISOR_VIRT_START XEN_VIRT_START
>> +#define MB(_mb) (_AC(_mb, UL) << 20)
>
> Can you move the GB here too for consistency.
>
> In fact it would be worth considering moving this to
> xen/include/xen/config.h and consolidating the x86 version too.
I will do.
I'm wondering, do we need to use ULL instead of UL in GB and MB?
--
Julien Grall
next prev parent reply other threads:[~2013-09-26 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 12:56 [PATCH v2 0/4] ARM: Support initrd loading Julien Grall
2013-09-26 12:56 ` [PATCH v2 1/4] xen/arm: Add macro MB Julien Grall
2013-09-26 14:32 ` Ian Campbell
2013-09-26 15:26 ` Julien Grall [this message]
2013-09-26 15:30 ` Ian Campbell
2013-09-26 15:32 ` Julien Grall
2013-09-26 15:52 ` Ian Campbell
2013-09-26 12:56 ` [PATCH v2 2/4] xen/arm: Add macro ALIGN Julien Grall
2013-09-26 14:30 ` Ian Campbell
2013-09-26 14:34 ` Andrew Cooper
2013-09-26 14:38 ` Ian Campbell
2013-09-26 14:41 ` Andrew Cooper
2013-09-26 15:26 ` Julien Grall
2013-09-26 12:56 ` [PATCH v2 3/4] xen/arm: Add support to load initrd in dom0 Julien Grall
2013-09-26 14:34 ` Ian Campbell
2013-09-26 12:56 ` [PATCH v2 4/4] xen/dts: Support Linux initrd DT bindings Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52445213.6010905@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=andre.przywara@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.