From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT
Date: Thu, 26 Sep 2013 09:38:27 -0600 [thread overview]
Message-ID: <524454F3.8000402@wwwdotorg.org> (raw)
In-Reply-To: <1380199684-20126-1-git-send-email-ldewangan@nvidia.com>
On 09/26/2013 06:48 AM, Laxman Dewangan wrote:
> Recent movement of all configurations of pin in the single call of
> pin_config_set(), it is aborting configuration if BIAS_PULL_PIN_DEFAULT
> is selected as return of configuration.
>
> The original idea was to just avoid any update on register for pull up/down
> configuration if this option is selected.
That doesn't sound correct. If a config option is specified in DT or the
mapping table, it should be applied to HW. If someone doesn't want a
particular config option applied, then it simply shouldn't be mentioned
in DT or the mapping table.
IIUC, BIAS_DEFAULT should be used only on HW where there is a concept of
a true default bias, and in that case, that is what should be applied.
next prev parent reply other threads:[~2013-09-26 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 12:48 [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT Laxman Dewangan
2013-09-26 12:48 ` [PATCH 2/2] pinctrl: palmas: remove non-require function Laxman Dewangan
2013-09-27 13:53 ` Linus Walleij
2013-09-26 15:38 ` Stephen Warren [this message]
2013-09-27 13:30 ` [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT Laxman Dewangan
2013-09-27 16:06 ` Stephen Warren
2013-09-28 11:38 ` Laxman Dewangan
2013-10-02 10:40 ` Linus Walleij
2013-10-02 11:10 ` Laxman Dewangan
2013-10-02 11:20 ` Heiko Stübner
2013-10-02 16:10 ` Stephen Warren
2013-09-27 14:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524454F3.8000402@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.