From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup
Date: Thu, 26 Sep 2013 18:28:31 +0000 [thread overview]
Message-ID: <52447CCF.8000301@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoTiHQ3EVDZ8POCkyN2ga95rF=u5ERfYsdZbX+toqAWmaQ@mail.gmail.com>
Hello.
On 09/26/2013 10:50 AM, Magnus Damm wrote:
>> Currently on the Lager board NFS timeouts/delays are seen when booting. That
>> turned out to happen because the SoC's ETH_LINK signal turns on and off after
>> each packet. It is connected to Micrel KSZ8041 PHY's LED0 signal. Ether LEDs
>> on the Lager board are named LINK and ACTIVE which corresponds to non-default
>> 01 setting of the PHY control register 1 bits 14-15. The 'sh_eth' driver resets
>> the PHY when opening the network device, so we have to set the mentioned bits
>> back to 01 from the default 00 value which causes bouncing of ETH_LINK. That
>> can be achieved using the PHY platform fixup mechanism if we also modify the
>> driver to use it..
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Hi Sergei,
> Thanks for your efforts on this. Nice to see that Ethernet for Lager
> board support is improving.
> Can you please share with us with link speeds you tested? I suspect
100 Mbit/s, full duplex.
> that this patch is only needed for some case, like for instance 100
> MBit Full Duplex.
Hm, why? :-O
> Fixing the PHY settings makes sense even though only
> a single mode needs it, but knowing which link speeds that are known
> to work would help a lot.
This patch should not depend on the link speed and duplex settings.
> Cheers,
> / magnus
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup
Date: Thu, 26 Sep 2013 22:28:31 +0400 [thread overview]
Message-ID: <52447CCF.8000301@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoTiHQ3EVDZ8POCkyN2ga95rF=u5ERfYsdZbX+toqAWmaQ@mail.gmail.com>
Hello.
On 09/26/2013 10:50 AM, Magnus Damm wrote:
>> Currently on the Lager board NFS timeouts/delays are seen when booting. That
>> turned out to happen because the SoC's ETH_LINK signal turns on and off after
>> each packet. It is connected to Micrel KSZ8041 PHY's LED0 signal. Ether LEDs
>> on the Lager board are named LINK and ACTIVE which corresponds to non-default
>> 01 setting of the PHY control register 1 bits 14-15. The 'sh_eth' driver resets
>> the PHY when opening the network device, so we have to set the mentioned bits
>> back to 01 from the default 00 value which causes bouncing of ETH_LINK. That
>> can be achieved using the PHY platform fixup mechanism if we also modify the
>> driver to use it..
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Hi Sergei,
> Thanks for your efforts on this. Nice to see that Ethernet for Lager
> board support is improving.
> Can you please share with us with link speeds you tested? I suspect
100 Mbit/s, full duplex.
> that this patch is only needed for some case, like for instance 100
> MBit Full Duplex.
Hm, why? :-O
> Fixing the PHY settings makes sense even though only
> a single mode needs it, but knowing which link speeds that are known
> to work would help a lot.
This patch should not depend on the link speed and duplex settings.
> Cheers,
> / magnus
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: "Simon Horman [Horms]" <horms@verge.net.au>,
SH-Linux <linux-sh@vger.kernel.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup
Date: Thu, 26 Sep 2013 22:28:31 +0400 [thread overview]
Message-ID: <52447CCF.8000301@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoTiHQ3EVDZ8POCkyN2ga95rF=u5ERfYsdZbX+toqAWmaQ@mail.gmail.com>
Hello.
On 09/26/2013 10:50 AM, Magnus Damm wrote:
>> Currently on the Lager board NFS timeouts/delays are seen when booting. That
>> turned out to happen because the SoC's ETH_LINK signal turns on and off after
>> each packet. It is connected to Micrel KSZ8041 PHY's LED0 signal. Ether LEDs
>> on the Lager board are named LINK and ACTIVE which corresponds to non-default
>> 01 setting of the PHY control register 1 bits 14-15. The 'sh_eth' driver resets
>> the PHY when opening the network device, so we have to set the mentioned bits
>> back to 01 from the default 00 value which causes bouncing of ETH_LINK. That
>> can be achieved using the PHY platform fixup mechanism if we also modify the
>> driver to use it..
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Hi Sergei,
> Thanks for your efforts on this. Nice to see that Ethernet for Lager
> board support is improving.
> Can you please share with us with link speeds you tested? I suspect
100 Mbit/s, full duplex.
> that this patch is only needed for some case, like for instance 100
> MBit Full Duplex.
Hm, why? :-O
> Fixing the PHY settings makes sense even though only
> a single mode needs it, but knowing which link speeds that are known
> to work would help a lot.
This patch should not depend on the link speed and duplex settings.
> Cheers,
> / magnus
WBR, Sergei
next prev parent reply other threads:[~2013-09-26 18:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 0:29 [PATCH] ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup Sergei Shtylyov
2013-09-14 0:29 ` Sergei Shtylyov
2013-09-14 0:29 ` Sergei Shtylyov
2013-09-19 21:20 ` Simon Horman
2013-09-19 21:20 ` Simon Horman
2013-09-19 21:20 ` Simon Horman
2013-09-21 17:14 ` Simon Horman
2013-09-21 17:14 ` Simon Horman
2013-09-21 17:14 ` Simon Horman
2013-09-26 6:50 ` Magnus Damm
2013-09-26 6:50 ` Magnus Damm
2013-09-26 6:50 ` Magnus Damm
2013-09-26 18:28 ` Sergei Shtylyov [this message]
2013-09-26 18:28 ` Sergei Shtylyov
2013-09-26 18:28 ` Sergei Shtylyov
2013-09-26 21:44 ` Simon Horman
2013-09-26 21:44 ` Simon Horman
2013-09-26 21:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52447CCF.8000301@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.