* possible bug in blacklist
@ 2013-09-24 23:57 Mandell Degerness
2013-09-26 23:51 ` Dan Mick
0 siblings, 1 reply; 3+ messages in thread
From: Mandell Degerness @ 2013-09-24 23:57 UTC (permalink / raw)
To: ceph-devel@vger.kernel.org
See trace below. We run this command on system restart in order to
clear any blacklist which was created while node was mis-behaving.
Now, rather than giving a reasonable error, it causes at Traceback:
[root@node-172-20-0-13 ~]# ceph osd blacklist rm 172.20.0.13
Traceback (most recent call last):
File "/usr/bin/ceph", line 774, in <module>
sys.exit(main())
File "/usr/bin/ceph", line 717, in main
sigdict, inbuf, verbose)
File "/usr/bin/ceph", line 375, in new_style_command
valid_dict = validate_command(sigdict, cmdargs, verbose)
File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
890, in validate_command
File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
715, in matchnum
File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
690, in validate_one
File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line 284, in valid
ValueError: need more than 1 value to unpack
[root@node-172-20-0-13 ~]# ceph --version
ceph version 0.67.3 (408cd61584c72c0d97b774b3d8f95c6b1b06341a)
[root@node-172-20-0-13 ~]#
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: possible bug in blacklist
2013-09-24 23:57 possible bug in blacklist Mandell Degerness
@ 2013-09-26 23:51 ` Dan Mick
2013-09-27 1:08 ` Dan Mick
0 siblings, 1 reply; 3+ messages in thread
From: Dan Mick @ 2013-09-26 23:51 UTC (permalink / raw)
To: Mandell Degerness; +Cc: ceph-devel@vger.kernel.org
Ah, yes, that's in the validator for CephEntityAddr; it's not checking
for the case that no nonce was supplied. I've filed
http://tracker.ceph.com/issues/6425.
On 09/24/2013 04:57 PM, Mandell Degerness wrote:
> See trace below. We run this command on system restart in order to
> clear any blacklist which was created while node was mis-behaving.
> Now, rather than giving a reasonable error, it causes at Traceback:
>
> [root@node-172-20-0-13 ~]# ceph osd blacklist rm 172.20.0.13
> Traceback (most recent call last):
> File "/usr/bin/ceph", line 774, in <module>
> sys.exit(main())
> File "/usr/bin/ceph", line 717, in main
> sigdict, inbuf, verbose)
> File "/usr/bin/ceph", line 375, in new_style_command
> valid_dict = validate_command(sigdict, cmdargs, verbose)
> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
> 890, in validate_command
> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
> 715, in matchnum
> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
> 690, in validate_one
> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line 284, in valid
> ValueError: need more than 1 value to unpack
> [root@node-172-20-0-13 ~]# ceph --version
> ceph version 0.67.3 (408cd61584c72c0d97b774b3d8f95c6b1b06341a)
> [root@node-172-20-0-13 ~]#
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: possible bug in blacklist
2013-09-26 23:51 ` Dan Mick
@ 2013-09-27 1:08 ` Dan Mick
0 siblings, 0 replies; 3+ messages in thread
From: Dan Mick @ 2013-09-27 1:08 UTC (permalink / raw)
To: Mandell Degerness; +Cc: ceph-devel@vger.kernel.org
Pull request created with fix.
On 09/26/2013 04:51 PM, Dan Mick wrote:
> Ah, yes, that's in the validator for CephEntityAddr; it's not checking
> for the case that no nonce was supplied. I've filed
> http://tracker.ceph.com/issues/6425.
>
> On 09/24/2013 04:57 PM, Mandell Degerness wrote:
>> See trace below. We run this command on system restart in order to
>> clear any blacklist which was created while node was mis-behaving.
>> Now, rather than giving a reasonable error, it causes at Traceback:
>>
>> [root@node-172-20-0-13 ~]# ceph osd blacklist rm 172.20.0.13
>> Traceback (most recent call last):
>> File "/usr/bin/ceph", line 774, in <module>
>> sys.exit(main())
>> File "/usr/bin/ceph", line 717, in main
>> sigdict, inbuf, verbose)
>> File "/usr/bin/ceph", line 375, in new_style_command
>> valid_dict = validate_command(sigdict, cmdargs, verbose)
>> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
>> 890, in validate_command
>> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
>> 715, in matchnum
>> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
>> 690, in validate_one
>> File "/usr/lib64/python2.7/site-packages/ceph_argparse.py", line
>> 284, in valid
>> ValueError: need more than 1 value to unpack
>> [root@node-172-20-0-13 ~]# ceph --version
>> ceph version 0.67.3 (408cd61584c72c0d97b774b3d8f95c6b1b06341a)
>> [root@node-172-20-0-13 ~]#
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-27 1:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-24 23:57 possible bug in blacklist Mandell Degerness
2013-09-26 23:51 ` Dan Mick
2013-09-27 1:08 ` Dan Mick
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.