* [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
@ 2013-09-26 16:15 ` Daniel Lezcano
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2013-09-26 16:15 UTC (permalink / raw)
To: michal.simek; +Cc: linux-arm-kernel, linux-pm
As the ux500 and the kirkwood driver, make the zynq driver a platform driver
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
arch/arm/mach-zynq/common.c | 7 +++++++
drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
index 5f25256..0f0d88f 100644
--- a/arch/arm/mach-zynq/common.c
+++ b/arch/arm/mach-zynq/common.c
@@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
{}
};
+static struct platform_device zynq_cpuidle_device = {
+ .name = "cpuidle-zynq",
+};
+
/**
* zynq_init_machine - System specific initialization, intended to be
* called from board specific initialization.
@@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
l2x0_of_init(0x02060000, 0xF0F0FFFF);
of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
+
+ if (of_machine_is_compatible("xlnx,zynq-7000"))
+ platform_device_register(&zynq_cpuidle_device);
}
static void __init zynq_timer_init(void)
diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c
index 38e03a1..c8bd261 100644
--- a/drivers/cpuidle/cpuidle-zynq.c
+++ b/drivers/cpuidle/cpuidle-zynq.c
@@ -70,14 +70,19 @@ static struct cpuidle_driver zynq_idle_driver = {
};
/* Initialize CPU idle by registering the idle states */
-static int __init zynq_cpuidle_init(void)
+static int __init zynq_cpuidle_probe(void)
{
- if (!of_machine_is_compatible("xlnx,zynq-7000"))
- return -ENODEV;
-
pr_info("Xilinx Zynq CpuIdle Driver started\n");
return cpuidle_register(&zynq_idle_driver, NULL);
}
-device_initcall(zynq_cpuidle_init);
+static struct platform_driver zynq_cpuidle_driver = {
+ .driver = {
+ .name = "cpuidle-zynq",
+ .owner = THIS_MODULE,
+ },
+ .probe = zynq_cpuidle_probe,
+};
+
+module_platform_driver(zynq_cpuidle_driver);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
@ 2013-09-26 16:15 ` Daniel Lezcano
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2013-09-26 16:15 UTC (permalink / raw)
To: linux-arm-kernel
As the ux500 and the kirkwood driver, make the zynq driver a platform driver
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
arch/arm/mach-zynq/common.c | 7 +++++++
drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
index 5f25256..0f0d88f 100644
--- a/arch/arm/mach-zynq/common.c
+++ b/arch/arm/mach-zynq/common.c
@@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
{}
};
+static struct platform_device zynq_cpuidle_device = {
+ .name = "cpuidle-zynq",
+};
+
/**
* zynq_init_machine - System specific initialization, intended to be
* called from board specific initialization.
@@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
l2x0_of_init(0x02060000, 0xF0F0FFFF);
of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
+
+ if (of_machine_is_compatible("xlnx,zynq-7000"))
+ platform_device_register(&zynq_cpuidle_device);
}
static void __init zynq_timer_init(void)
diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c
index 38e03a1..c8bd261 100644
--- a/drivers/cpuidle/cpuidle-zynq.c
+++ b/drivers/cpuidle/cpuidle-zynq.c
@@ -70,14 +70,19 @@ static struct cpuidle_driver zynq_idle_driver = {
};
/* Initialize CPU idle by registering the idle states */
-static int __init zynq_cpuidle_init(void)
+static int __init zynq_cpuidle_probe(void)
{
- if (!of_machine_is_compatible("xlnx,zynq-7000"))
- return -ENODEV;
-
pr_info("Xilinx Zynq CpuIdle Driver started\n");
return cpuidle_register(&zynq_idle_driver, NULL);
}
-device_initcall(zynq_cpuidle_init);
+static struct platform_driver zynq_cpuidle_driver = {
+ .driver = {
+ .name = "cpuidle-zynq",
+ .owner = THIS_MODULE,
+ },
+ .probe = zynq_cpuidle_probe,
+};
+
+module_platform_driver(zynq_cpuidle_driver);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
2013-09-26 16:15 ` Daniel Lezcano
@ 2013-09-27 5:12 ` Michal Simek
-1 siblings, 0 replies; 8+ messages in thread
From: Michal Simek @ 2013-09-27 5:12 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: michal.simek, linux-arm-kernel, linux-pm
Hi Daniel,
On 09/26/2013 06:15 PM, Daniel Lezcano wrote:
> As the ux500 and the kirkwood driver, make the zynq driver a platform driver
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm/mach-zynq/common.c | 7 +++++++
> drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
> 2 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
> index 5f25256..0f0d88f 100644
> --- a/arch/arm/mach-zynq/common.c
> +++ b/arch/arm/mach-zynq/common.c
> @@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
> {}
> };
>
> +static struct platform_device zynq_cpuidle_device = {
> + .name = "cpuidle-zynq",
> +};
> +
> /**
> * zynq_init_machine - System specific initialization, intended to be
> * called from board specific initialization.
> @@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
> l2x0_of_init(0x02060000, 0xF0F0FFFF);
>
> of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
> +
> + if (of_machine_is_compatible("xlnx,zynq-7000"))
This is not needed because all zynq platforms have this compatibility string
and there is no any other clone.
The rest is fine.
Thanks,
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread* [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
@ 2013-09-27 5:12 ` Michal Simek
0 siblings, 0 replies; 8+ messages in thread
From: Michal Simek @ 2013-09-27 5:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Daniel,
On 09/26/2013 06:15 PM, Daniel Lezcano wrote:
> As the ux500 and the kirkwood driver, make the zynq driver a platform driver
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm/mach-zynq/common.c | 7 +++++++
> drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
> 2 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
> index 5f25256..0f0d88f 100644
> --- a/arch/arm/mach-zynq/common.c
> +++ b/arch/arm/mach-zynq/common.c
> @@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
> {}
> };
>
> +static struct platform_device zynq_cpuidle_device = {
> + .name = "cpuidle-zynq",
> +};
> +
> /**
> * zynq_init_machine - System specific initialization, intended to be
> * called from board specific initialization.
> @@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
> l2x0_of_init(0x02060000, 0xF0F0FFFF);
>
> of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
> +
> + if (of_machine_is_compatible("xlnx,zynq-7000"))
This is not needed because all zynq platforms have this compatibility string
and there is no any other clone.
The rest is fine.
Thanks,
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
2013-09-27 5:12 ` Michal Simek
@ 2013-09-27 7:21 ` Daniel Lezcano
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2013-09-27 7:21 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-arm-kernel, linux-pm
On 09/27/2013 07:12 AM, Michal Simek wrote:
> Hi Daniel,
>
> On 09/26/2013 06:15 PM, Daniel Lezcano wrote:
>> As the ux500 and the kirkwood driver, make the zynq driver a platform driver
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> arch/arm/mach-zynq/common.c | 7 +++++++
>> drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
>> 2 files changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
>> index 5f25256..0f0d88f 100644
>> --- a/arch/arm/mach-zynq/common.c
>> +++ b/arch/arm/mach-zynq/common.c
>> @@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
>> {}
>> };
>>
>> +static struct platform_device zynq_cpuidle_device = {
>> + .name = "cpuidle-zynq",
>> +};
>> +
>> /**
>> * zynq_init_machine - System specific initialization, intended to be
>> * called from board specific initialization.
>> @@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
>> l2x0_of_init(0x02060000, 0xF0F0FFFF);
>>
>> of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
>> +
>> + if (of_machine_is_compatible("xlnx,zynq-7000"))
>
> This is not needed because all zynq platforms have this compatibility string
> and there is no any other clone.
Ah, ok. So it is not needed in the current code. I will write its
removal in a separate patch.
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 8+ messages in thread* [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
@ 2013-09-27 7:21 ` Daniel Lezcano
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2013-09-27 7:21 UTC (permalink / raw)
To: linux-arm-kernel
On 09/27/2013 07:12 AM, Michal Simek wrote:
> Hi Daniel,
>
> On 09/26/2013 06:15 PM, Daniel Lezcano wrote:
>> As the ux500 and the kirkwood driver, make the zynq driver a platform driver
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> arch/arm/mach-zynq/common.c | 7 +++++++
>> drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
>> 2 files changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
>> index 5f25256..0f0d88f 100644
>> --- a/arch/arm/mach-zynq/common.c
>> +++ b/arch/arm/mach-zynq/common.c
>> @@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
>> {}
>> };
>>
>> +static struct platform_device zynq_cpuidle_device = {
>> + .name = "cpuidle-zynq",
>> +};
>> +
>> /**
>> * zynq_init_machine - System specific initialization, intended to be
>> * called from board specific initialization.
>> @@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
>> l2x0_of_init(0x02060000, 0xF0F0FFFF);
>>
>> of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
>> +
>> + if (of_machine_is_compatible("xlnx,zynq-7000"))
>
> This is not needed because all zynq platforms have this compatibility string
> and there is no any other clone.
Ah, ok. So it is not needed in the current code. I will write its
removal in a separate patch.
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
2013-09-27 7:21 ` Daniel Lezcano
@ 2013-09-27 8:14 ` Michal Simek
-1 siblings, 0 replies; 8+ messages in thread
From: Michal Simek @ 2013-09-27 8:14 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: Michal Simek, linux-arm-kernel, linux-pm
On 09/27/2013 09:21 AM, Daniel Lezcano wrote:
> On 09/27/2013 07:12 AM, Michal Simek wrote:
>> Hi Daniel,
>>
>> On 09/26/2013 06:15 PM, Daniel Lezcano wrote:
>>> As the ux500 and the kirkwood driver, make the zynq driver a platform driver
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>>> arch/arm/mach-zynq/common.c | 7 +++++++
>>> drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
>>> 2 files changed, 17 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
>>> index 5f25256..0f0d88f 100644
>>> --- a/arch/arm/mach-zynq/common.c
>>> +++ b/arch/arm/mach-zynq/common.c
>>> @@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
>>> {}
>>> };
>>>
>>> +static struct platform_device zynq_cpuidle_device = {
>>> + .name = "cpuidle-zynq",
>>> +};
>>> +
>>> /**
>>> * zynq_init_machine - System specific initialization, intended to be
>>> * called from board specific initialization.
>>> @@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
>>> l2x0_of_init(0x02060000, 0xF0F0FFFF);
>>>
>>> of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
>>> +
>>> + if (of_machine_is_compatible("xlnx,zynq-7000"))
>>
>> This is not needed because all zynq platforms have this compatibility string
>> and there is no any other clone.
>
> Ah, ok. So it is not needed in the current code. I will write its removal in a separate patch.
ok. Thanks.
Feel free to give there my ACK too.
Thanks,
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread* [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver
@ 2013-09-27 8:14 ` Michal Simek
0 siblings, 0 replies; 8+ messages in thread
From: Michal Simek @ 2013-09-27 8:14 UTC (permalink / raw)
To: linux-arm-kernel
On 09/27/2013 09:21 AM, Daniel Lezcano wrote:
> On 09/27/2013 07:12 AM, Michal Simek wrote:
>> Hi Daniel,
>>
>> On 09/26/2013 06:15 PM, Daniel Lezcano wrote:
>>> As the ux500 and the kirkwood driver, make the zynq driver a platform driver
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>>> arch/arm/mach-zynq/common.c | 7 +++++++
>>> drivers/cpuidle/cpuidle-zynq.c | 15 ++++++++++-----
>>> 2 files changed, 17 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
>>> index 5f25256..0f0d88f 100644
>>> --- a/arch/arm/mach-zynq/common.c
>>> +++ b/arch/arm/mach-zynq/common.c
>>> @@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
>>> {}
>>> };
>>>
>>> +static struct platform_device zynq_cpuidle_device = {
>>> + .name = "cpuidle-zynq",
>>> +};
>>> +
>>> /**
>>> * zynq_init_machine - System specific initialization, intended to be
>>> * called from board specific initialization.
>>> @@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
>>> l2x0_of_init(0x02060000, 0xF0F0FFFF);
>>>
>>> of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
>>> +
>>> + if (of_machine_is_compatible("xlnx,zynq-7000"))
>>
>> This is not needed because all zynq platforms have this compatibility string
>> and there is no any other clone.
>
> Ah, ok. So it is not needed in the current code. I will write its removal in a separate patch.
ok. Thanks.
Feel free to give there my ACK too.
Thanks,
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-09-27 8:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-26 16:15 [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver Daniel Lezcano
2013-09-26 16:15 ` Daniel Lezcano
2013-09-27 5:12 ` Michal Simek
2013-09-27 5:12 ` Michal Simek
2013-09-27 7:21 ` Daniel Lezcano
2013-09-27 7:21 ` Daniel Lezcano
2013-09-27 8:14 ` Michal Simek
2013-09-27 8:14 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.