All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: michal.simek@xilinx.com
Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: zynq: cpuidle: Remove useless compatibility string
Date: Fri, 27 Sep 2013 10:19:19 +0200	[thread overview]
Message-ID: <52453F87.2090508@linaro.org> (raw)
In-Reply-To: <1380269867-18336-1-git-send-email-daniel.lezcano@linaro.org>

On 09/27/2013 10:17 AM, Daniel Lezcano wrote:
> All zynq platforms have this compatibility string and there is no any other
> clone.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

As I don't have the hardware, this patchset is just compile tested.

> ---
>   drivers/cpuidle/cpuidle-zynq.c |    4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c
> index 38e03a1..ab6c4b4 100644
> --- a/drivers/cpuidle/cpuidle-zynq.c
> +++ b/drivers/cpuidle/cpuidle-zynq.c
> @@ -28,7 +28,6 @@
>   #include <linux/init.h>
>   #include <linux/cpu_pm.h>
>   #include <linux/cpuidle.h>
> -#include <linux/of.h>
>   #include <asm/proc-fns.h>
>   #include <asm/cpuidle.h>
>
> @@ -72,9 +71,6 @@ static struct cpuidle_driver zynq_idle_driver = {
>   /* Initialize CPU idle by registering the idle states */
>   static int __init zynq_cpuidle_init(void)
>   {
> -	if (!of_machine_is_compatible("xlnx,zynq-7000"))
> -		return -ENODEV;
> -
>   	pr_info("Xilinx Zynq CpuIdle Driver started\n");
>
>   	return cpuidle_register(&zynq_idle_driver, NULL);
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: zynq: cpuidle: Remove useless compatibility string
Date: Fri, 27 Sep 2013 10:19:19 +0200	[thread overview]
Message-ID: <52453F87.2090508@linaro.org> (raw)
In-Reply-To: <1380269867-18336-1-git-send-email-daniel.lezcano@linaro.org>

On 09/27/2013 10:17 AM, Daniel Lezcano wrote:
> All zynq platforms have this compatibility string and there is no any other
> clone.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

As I don't have the hardware, this patchset is just compile tested.

> ---
>   drivers/cpuidle/cpuidle-zynq.c |    4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c
> index 38e03a1..ab6c4b4 100644
> --- a/drivers/cpuidle/cpuidle-zynq.c
> +++ b/drivers/cpuidle/cpuidle-zynq.c
> @@ -28,7 +28,6 @@
>   #include <linux/init.h>
>   #include <linux/cpu_pm.h>
>   #include <linux/cpuidle.h>
> -#include <linux/of.h>
>   #include <asm/proc-fns.h>
>   #include <asm/cpuidle.h>
>
> @@ -72,9 +71,6 @@ static struct cpuidle_driver zynq_idle_driver = {
>   /* Initialize CPU idle by registering the idle states */
>   static int __init zynq_cpuidle_init(void)
>   {
> -	if (!of_machine_is_compatible("xlnx,zynq-7000"))
> -		return -ENODEV;
> -
>   	pr_info("Xilinx Zynq CpuIdle Driver started\n");
>
>   	return cpuidle_register(&zynq_idle_driver, NULL);
>


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  parent reply	other threads:[~2013-09-27  8:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27  8:17 [PATCH 1/2] ARM: zynq: cpuidle: Remove useless compatibility string Daniel Lezcano
2013-09-27  8:17 ` Daniel Lezcano
2013-09-27  8:17 ` [PATCH 2/2] ARM: zynq: cpuidle: convert to platform driver Daniel Lezcano
2013-09-27  8:17   ` Daniel Lezcano
2013-09-27  8:19   ` Michal Simek
2013-09-27  8:19     ` Michal Simek
2013-09-27  8:19 ` [PATCH 1/2] ARM: zynq: cpuidle: Remove useless compatibility string Michal Simek
2013-09-27  8:19   ` Michal Simek
2013-09-27  8:35   ` Daniel Lezcano
2013-09-27  8:35     ` Daniel Lezcano
2013-09-27  8:51     ` Michal Simek
2013-09-27  8:51       ` Michal Simek
     [not found]     ` <5245471F.6040707@xilinx.com>
2013-09-27 15:58       ` Sören Brinkmann
2013-09-27 15:58         ` Sören Brinkmann
2013-09-27 16:36         ` Daniel Lezcano
2013-09-27 16:36           ` Daniel Lezcano
2013-09-27 16:40           ` Sören Brinkmann
2013-09-27 16:40             ` Sören Brinkmann
2013-09-27  8:19 ` Daniel Lezcano [this message]
2013-09-27  8:19   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52453F87.2090508@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.