From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Rob Herring <robherring2@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <rob.herring@calxeda.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/6] cpuidle: calxeda: add cpu_pm_enter/exit calls
Date: Fri, 27 Sep 2013 10:45:38 +0200 [thread overview]
Message-ID: <524545B2.7000608@linaro.org> (raw)
In-Reply-To: <1380248694-13388-3-git-send-email-robherring2@gmail.com>
On 09/27/2013 04:24 AM, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Wnen powergating the core, we need to call cpu pm notifiers to save VFP
> state (!SMP only) and resetting the breakpoint h/w.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-pm@vger.kernel.org
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Shouldn't this patch be the first in the series ?
> ---
> drivers/cpuidle/cpuidle-calxeda.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c
> index 01cfecf3..b04767a 100644
> --- a/drivers/cpuidle/cpuidle-calxeda.c
> +++ b/drivers/cpuidle/cpuidle-calxeda.c
> @@ -21,6 +21,7 @@
> */
>
> #include <linux/cpuidle.h>
> +#include <linux/cpu_pm.h>
> #include <linux/init.h>
> #include <linux/of.h>
> #include <asm/cpuidle.h>
> @@ -39,7 +40,10 @@ static int calxeda_pwrdown_idle(struct cpuidle_device *dev,
> struct cpuidle_driver *drv,
> int index)
> {
> + cpu_pm_enter();
> cpu_suspend(0, calxeda_idle_finish);
> + cpu_pm_exit();
> +
> return index;
> }
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] cpuidle: calxeda: add cpu_pm_enter/exit calls
Date: Fri, 27 Sep 2013 10:45:38 +0200 [thread overview]
Message-ID: <524545B2.7000608@linaro.org> (raw)
In-Reply-To: <1380248694-13388-3-git-send-email-robherring2@gmail.com>
On 09/27/2013 04:24 AM, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Wnen powergating the core, we need to call cpu pm notifiers to save VFP
> state (!SMP only) and resetting the breakpoint h/w.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-pm at vger.kernel.org
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Shouldn't this patch be the first in the series ?
> ---
> drivers/cpuidle/cpuidle-calxeda.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c
> index 01cfecf3..b04767a 100644
> --- a/drivers/cpuidle/cpuidle-calxeda.c
> +++ b/drivers/cpuidle/cpuidle-calxeda.c
> @@ -21,6 +21,7 @@
> */
>
> #include <linux/cpuidle.h>
> +#include <linux/cpu_pm.h>
> #include <linux/init.h>
> #include <linux/of.h>
> #include <asm/cpuidle.h>
> @@ -39,7 +40,10 @@ static int calxeda_pwrdown_idle(struct cpuidle_device *dev,
> struct cpuidle_driver *drv,
> int index)
> {
> + cpu_pm_enter();
> cpu_suspend(0, calxeda_idle_finish);
> + cpu_pm_exit();
> +
> return index;
> }
>
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-09-27 8:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 2:24 [PATCH v4 0/6] PSCI support for highbank Rob Herring
2013-09-27 2:24 ` Rob Herring
2013-09-27 2:24 ` [PATCH 1/6] cpuidle: calxeda: add support to use PSCI calls Rob Herring
2013-09-27 2:24 ` Rob Herring
2013-09-27 2:24 ` Rob Herring
2013-09-27 8:44 ` Daniel Lezcano
2013-09-27 8:44 ` Daniel Lezcano
2013-09-27 2:24 ` [PATCH 2/6] cpuidle: calxeda: add cpu_pm_enter/exit calls Rob Herring
2013-09-27 2:24 ` Rob Herring
2013-09-27 8:45 ` Daniel Lezcano [this message]
2013-09-27 8:45 ` Daniel Lezcano
2013-09-27 2:24 ` [PATCH 3/6] cpuidle: calxeda: add ecx-2000 support Rob Herring
2013-09-27 2:24 ` Rob Herring
2013-09-27 8:47 ` Daniel Lezcano
2013-09-27 8:47 ` Daniel Lezcano
2013-09-27 12:14 ` Rob Herring
2013-09-27 12:14 ` Rob Herring
2013-09-27 2:24 ` [PATCH 4/6] ARM: PSCI: remove unnecessary include of arm-gic.h Rob Herring
2013-09-27 2:24 ` Rob Herring
2013-09-27 2:24 ` [PATCH 5/6] ARM: highbank: adapt to use ARM PSCI calls Rob Herring
2013-09-27 2:24 ` Rob Herring
2013-09-27 2:24 ` [PATCH 6/6] dts: calxeda: add ARM PSCI binding Rob Herring
2013-09-27 2:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524545B2.7000608@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.