* bugfix magnetometer output registers @ 2013-09-24 14:51 Denis CIOCCA 2013-09-24 14:51 ` [PATCH] iio:magnetometer: Bugfix magnetometer default " Denis CIOCCA 0 siblings, 1 reply; 4+ messages in thread From: Denis CIOCCA @ 2013-09-24 14:51 UTC (permalink / raw) To: jic23; +Cc: linux-iio, lee.jones Hi, there is a bug inside magnetometer output default registers, the output data must be big endian and start from different address. Thanks, Denis ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] iio:magnetometer: Bugfix magnetometer default output registers 2013-09-24 14:51 bugfix magnetometer output registers Denis CIOCCA @ 2013-09-24 14:51 ` Denis CIOCCA 2013-09-28 11:04 ` Jonathan Cameron 0 siblings, 1 reply; 4+ messages in thread From: Denis CIOCCA @ 2013-09-24 14:51 UTC (permalink / raw) To: jic23; +Cc: linux-iio, lee.jones, Denis Ciocca Signed-off-by: Denis Ciocca <denis.ciocca@st.com> --- drivers/iio/magnetometer/st_magn_core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/magnetometer/st_magn_core.c b/drivers/iio/magnetometer/st_magn_core.c index e8d2849..cab3bc7 100644 --- a/drivers/iio/magnetometer/st_magn_core.c +++ b/drivers/iio/magnetometer/st_magn_core.c @@ -29,9 +29,9 @@ #define ST_MAGN_NUMBER_DATA_CHANNELS 3 /* DEFAULT VALUE FOR SENSORS */ -#define ST_MAGN_DEFAULT_OUT_X_L_ADDR 0X04 -#define ST_MAGN_DEFAULT_OUT_Y_L_ADDR 0X08 -#define ST_MAGN_DEFAULT_OUT_Z_L_ADDR 0X06 +#define ST_MAGN_DEFAULT_OUT_X_H_ADDR 0X03 +#define ST_MAGN_DEFAULT_OUT_Y_H_ADDR 0X07 +#define ST_MAGN_DEFAULT_OUT_Z_H_ADDR 0X05 /* FULLSCALE */ #define ST_MAGN_FS_AVL_1300MG 1300 @@ -117,16 +117,16 @@ static const struct iio_chan_spec st_magn_16bit_channels[] = { ST_SENSORS_LSM_CHANNELS(IIO_MAGN, BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), - ST_SENSORS_SCAN_X, 1, IIO_MOD_X, 's', IIO_LE, 16, 16, - ST_MAGN_DEFAULT_OUT_X_L_ADDR), + ST_SENSORS_SCAN_X, 1, IIO_MOD_X, 's', IIO_BE, 16, 16, + ST_MAGN_DEFAULT_OUT_X_H_ADDR), ST_SENSORS_LSM_CHANNELS(IIO_MAGN, BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), - ST_SENSORS_SCAN_Y, 1, IIO_MOD_Y, 's', IIO_LE, 16, 16, - ST_MAGN_DEFAULT_OUT_Y_L_ADDR), + ST_SENSORS_SCAN_Y, 1, IIO_MOD_Y, 's', IIO_BE, 16, 16, + ST_MAGN_DEFAULT_OUT_Y_H_ADDR), ST_SENSORS_LSM_CHANNELS(IIO_MAGN, BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), - ST_SENSORS_SCAN_Z, 1, IIO_MOD_Z, 's', IIO_LE, 16, 16, - ST_MAGN_DEFAULT_OUT_Z_L_ADDR), + ST_SENSORS_SCAN_Z, 1, IIO_MOD_Z, 's', IIO_BE, 16, 16, + ST_MAGN_DEFAULT_OUT_Z_H_ADDR), IIO_CHAN_SOFT_TIMESTAMP(3) }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio:magnetometer: Bugfix magnetometer default output registers 2013-09-24 14:51 ` [PATCH] iio:magnetometer: Bugfix magnetometer default " Denis CIOCCA @ 2013-09-28 11:04 ` Jonathan Cameron 2013-09-28 12:30 ` Denis Ciocca 0 siblings, 1 reply; 4+ messages in thread From: Jonathan Cameron @ 2013-09-28 11:04 UTC (permalink / raw) To: Denis CIOCCA; +Cc: linux-iio, lee.jones On 09/24/13 15:51, Denis CIOCCA wrote: > Signed-off-by: Denis Ciocca <denis.ciocca@st.com> Applied to the togreg branch of iio.git Does this want to go to stable as well? Thanks, > --- > drivers/iio/magnetometer/st_magn_core.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/iio/magnetometer/st_magn_core.c b/drivers/iio/magnetometer/st_magn_core.c > index e8d2849..cab3bc7 100644 > --- a/drivers/iio/magnetometer/st_magn_core.c > +++ b/drivers/iio/magnetometer/st_magn_core.c > @@ -29,9 +29,9 @@ > #define ST_MAGN_NUMBER_DATA_CHANNELS 3 > > /* DEFAULT VALUE FOR SENSORS */ > -#define ST_MAGN_DEFAULT_OUT_X_L_ADDR 0X04 > -#define ST_MAGN_DEFAULT_OUT_Y_L_ADDR 0X08 > -#define ST_MAGN_DEFAULT_OUT_Z_L_ADDR 0X06 > +#define ST_MAGN_DEFAULT_OUT_X_H_ADDR 0X03 > +#define ST_MAGN_DEFAULT_OUT_Y_H_ADDR 0X07 > +#define ST_MAGN_DEFAULT_OUT_Z_H_ADDR 0X05 > > /* FULLSCALE */ > #define ST_MAGN_FS_AVL_1300MG 1300 > @@ -117,16 +117,16 @@ > static const struct iio_chan_spec st_magn_16bit_channels[] = { > ST_SENSORS_LSM_CHANNELS(IIO_MAGN, > BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), > - ST_SENSORS_SCAN_X, 1, IIO_MOD_X, 's', IIO_LE, 16, 16, > - ST_MAGN_DEFAULT_OUT_X_L_ADDR), > + ST_SENSORS_SCAN_X, 1, IIO_MOD_X, 's', IIO_BE, 16, 16, > + ST_MAGN_DEFAULT_OUT_X_H_ADDR), > ST_SENSORS_LSM_CHANNELS(IIO_MAGN, > BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), > - ST_SENSORS_SCAN_Y, 1, IIO_MOD_Y, 's', IIO_LE, 16, 16, > - ST_MAGN_DEFAULT_OUT_Y_L_ADDR), > + ST_SENSORS_SCAN_Y, 1, IIO_MOD_Y, 's', IIO_BE, 16, 16, > + ST_MAGN_DEFAULT_OUT_Y_H_ADDR), > ST_SENSORS_LSM_CHANNELS(IIO_MAGN, > BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), > - ST_SENSORS_SCAN_Z, 1, IIO_MOD_Z, 's', IIO_LE, 16, 16, > - ST_MAGN_DEFAULT_OUT_Z_L_ADDR), > + ST_SENSORS_SCAN_Z, 1, IIO_MOD_Z, 's', IIO_BE, 16, 16, > + ST_MAGN_DEFAULT_OUT_Z_H_ADDR), > IIO_CHAN_SOFT_TIMESTAMP(3) > }; > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio:magnetometer: Bugfix magnetometer default output registers 2013-09-28 11:04 ` Jonathan Cameron @ 2013-09-28 12:30 ` Denis Ciocca 0 siblings, 0 replies; 4+ messages in thread From: Denis Ciocca @ 2013-09-28 12:30 UTC (permalink / raw) To: Jonathan Cameron; +Cc: linux-iio, Denis CIOCCA, lee.jones [-- Attachment #1: Type: text/plain, Size: 2736 bytes --] Yes thanks! Denis On Sep 28, 2013 12:04 PM, "Jonathan Cameron" <jic23@kernel.org> wrote: > On 09/24/13 15:51, Denis CIOCCA wrote: > > Signed-off-by: Denis Ciocca <denis.ciocca@st.com> > Applied to the togreg branch of iio.git > > Does this want to go to stable as well? > > Thanks, > > --- > > drivers/iio/magnetometer/st_magn_core.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/iio/magnetometer/st_magn_core.c > b/drivers/iio/magnetometer/st_magn_core.c > > index e8d2849..cab3bc7 100644 > > --- a/drivers/iio/magnetometer/st_magn_core.c > > +++ b/drivers/iio/magnetometer/st_magn_core.c > > @@ -29,9 +29,9 @@ > > #define ST_MAGN_NUMBER_DATA_CHANNELS 3 > > > > /* DEFAULT VALUE FOR SENSORS */ > > -#define ST_MAGN_DEFAULT_OUT_X_L_ADDR 0X04 > > -#define ST_MAGN_DEFAULT_OUT_Y_L_ADDR 0X08 > > -#define ST_MAGN_DEFAULT_OUT_Z_L_ADDR 0X06 > > +#define ST_MAGN_DEFAULT_OUT_X_H_ADDR 0X03 > > +#define ST_MAGN_DEFAULT_OUT_Y_H_ADDR 0X07 > > +#define ST_MAGN_DEFAULT_OUT_Z_H_ADDR 0X05 > > > > /* FULLSCALE */ > > #define ST_MAGN_FS_AVL_1300MG 1300 > > @@ -117,16 +117,16 @@ > > static const struct iio_chan_spec st_magn_16bit_channels[] = { > > ST_SENSORS_LSM_CHANNELS(IIO_MAGN, > > BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), > > - ST_SENSORS_SCAN_X, 1, IIO_MOD_X, 's', IIO_LE, 16, > 16, > > - ST_MAGN_DEFAULT_OUT_X_L_ADDR), > > + ST_SENSORS_SCAN_X, 1, IIO_MOD_X, 's', IIO_BE, 16, > 16, > > + ST_MAGN_DEFAULT_OUT_X_H_ADDR), > > ST_SENSORS_LSM_CHANNELS(IIO_MAGN, > > BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), > > - ST_SENSORS_SCAN_Y, 1, IIO_MOD_Y, 's', IIO_LE, 16, > 16, > > - ST_MAGN_DEFAULT_OUT_Y_L_ADDR), > > + ST_SENSORS_SCAN_Y, 1, IIO_MOD_Y, 's', IIO_BE, 16, > 16, > > + ST_MAGN_DEFAULT_OUT_Y_H_ADDR), > > ST_SENSORS_LSM_CHANNELS(IIO_MAGN, > > BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), > > - ST_SENSORS_SCAN_Z, 1, IIO_MOD_Z, 's', IIO_LE, 16, > 16, > > - ST_MAGN_DEFAULT_OUT_Z_L_ADDR), > > + ST_SENSORS_SCAN_Z, 1, IIO_MOD_Z, 's', IIO_BE, 16, > 16, > > + ST_MAGN_DEFAULT_OUT_Z_H_ADDR), > > IIO_CHAN_SOFT_TIMESTAMP(3) > > }; > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > [-- Attachment #2: Type: text/html, Size: 3518 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-28 12:30 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-09-24 14:51 bugfix magnetometer output registers Denis CIOCCA 2013-09-24 14:51 ` [PATCH] iio:magnetometer: Bugfix magnetometer default " Denis CIOCCA 2013-09-28 11:04 ` Jonathan Cameron 2013-09-28 12:30 ` Denis Ciocca
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.