* [eclipse-poky][PATCH v2] OptionsPage.java: improved handling of path concatenation in new project
@ 2016-05-18 20:29 Humberto Ibarra
2016-05-19 16:32 ` timothy.t.orling
0 siblings, 1 reply; 3+ messages in thread
From: Humberto Ibarra @ 2016-05-18 20:29 UTC (permalink / raw)
To: yocto
When creating a new Yocto Bitbake Commander project, the folder
separator is not being handled corretly. The problem is a folder and
a file to be concatenated are joined as Strings instead of paths.
This patch solves the issue by using a path joioning mechanism instead
of simply concatenating strings.
[Yocto #9648]
---
.../src/org/yocto/bc/ui/wizards/install/OptionsPage.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
index bd91ef9..3a2caa0 100644
--- a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
+++ b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
@@ -166,17 +166,17 @@ public class OptionsPage extends FiniteStateWizardPage {
return false;
}
- String projectPath = projectLoc + txtProjectName.getText();
+ String projectPath = new File(projectLoc,txtProjectName.getText()).getPath();
File prj_dir=new File(projectPath);
if(!prj_dir.isDirectory() || !prj_dir.exists()) {
if(!new File(projectPath + File.separator + InstallWizard.VALIDATION_FILE).exists()) {
- setErrorMessage("Directory " + txtProjectLocation.getText() + txtProjectName.getText() + " is an invalid poky directory.");
+ setErrorMessage("Directory " + projectPath + " is an invalid poky directory.");
return false;
}
}
try {
- URI location = new URI("file://" + txtProjectLocation.getText()+File.separator+txtProjectName.getText());
+ URI location = new URI("file://" + projectPath);
IStatus status = ResourcesPlugin.getWorkspace().validateProjectLocationURI(proj, location);
if (!status.isOK()) {
setErrorMessage(status.getMessage());
--
2.4.11
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [eclipse-poky][PATCH v2] OptionsPage.java: improved handling of path concatenation in new project
2016-05-18 20:29 [eclipse-poky][PATCH v2] OptionsPage.java: improved handling of path concatenation in new project Humberto Ibarra
@ 2016-05-19 16:32 ` timothy.t.orling
2016-05-19 17:32 ` timothy.t.orling
0 siblings, 1 reply; 3+ messages in thread
From: timothy.t.orling @ 2016-05-19 16:32 UTC (permalink / raw)
To: Humberto Ibarra; +Cc: yocto
Please add your 'Signed-off-by:'
(e.g. use 'git commit -s')
--Tim
> When creating a new Yocto Bitbake Commander project, the folder
> separator is not being handled corretly. The problem is a folder and
> a file to be concatenated are joined as Strings instead of paths.
>
> This patch solves the issue by using a path joioning mechanism instead
> of simply concatenating strings.
>
> [Yocto #9648]
> ---
> .../src/org/yocto/bc/ui/wizards/install/OptionsPage.java | 6
> +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
> b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
> index bd91ef9..3a2caa0 100644
> ---
> a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
> +++
> b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
> @@ -166,17 +166,17 @@ public class OptionsPage extends
> FiniteStateWizardPage {
> return false;
> }
>
> - String projectPath = projectLoc + txtProjectName.getText();
> + String projectPath = new
> File(projectLoc,txtProjectName.getText()).getPath();
> File prj_dir=new File(projectPath);
> if(!prj_dir.isDirectory() || !prj_dir.exists()) {
> if(!new File(projectPath + File.separator +
> InstallWizard.VALIDATION_FILE).exists()) {
> - setErrorMessage("Directory " + txtProjectLocation.getText() +
> txtProjectName.getText() + " is an invalid poky directory.");
> + setErrorMessage("Directory " + projectPath + " is an invalid poky
> directory.");
> return false;
> }
> }
>
> try {
> - URI location = new URI("file://" +
> txtProjectLocation.getText()+File.separator+txtProjectName.getText());
> + URI location = new URI("file://" + projectPath);
> IStatus status =
> ResourcesPlugin.getWorkspace().validateProjectLocationURI(proj,
> location);
> if (!status.isOK()) {
> setErrorMessage(status.getMessage());
> --
> 2.4.11
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [eclipse-poky][PATCH v2] OptionsPage.java: improved handling of path concatenation in new project
2016-05-19 16:32 ` timothy.t.orling
@ 2016-05-19 17:32 ` timothy.t.orling
0 siblings, 0 replies; 3+ messages in thread
From: timothy.t.orling @ 2016-05-19 17:32 UTC (permalink / raw)
To: timothy.t.orling; +Cc: yocto
Tested for luna-master plugin branch and yocto-2.0.1 docs branch.
Tested-by: Tim Orling <timothy.t.orling@linux.intel.com>
> Please add your 'Signed-off-by:'
> (e.g. use 'git commit -s')
>
> --Tim
>
>> When creating a new Yocto Bitbake Commander project, the folder
>> separator is not being handled corretly. The problem is a folder and
>> a file to be concatenated are joined as Strings instead of paths.
>>
>> This patch solves the issue by using a path joioning mechanism instead
>> of simply concatenating strings.
>>
>> [Yocto #9648]
>> ---
>> .../src/org/yocto/bc/ui/wizards/install/OptionsPage.java | 6
>> +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git
>> a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
>> b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
>> index bd91ef9..3a2caa0 100644
>> ---
>> a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
>> +++
>> b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
>> @@ -166,17 +166,17 @@ public class OptionsPage extends
>> FiniteStateWizardPage {
>> return false;
>> }
>>
>> - String projectPath = projectLoc + txtProjectName.getText();
>> + String projectPath = new
>> File(projectLoc,txtProjectName.getText()).getPath();
>> File prj_dir=new File(projectPath);
>> if(!prj_dir.isDirectory() || !prj_dir.exists()) {
>> if(!new File(projectPath + File.separator +
>> InstallWizard.VALIDATION_FILE).exists()) {
>> - setErrorMessage("Directory " + txtProjectLocation.getText() +
>> txtProjectName.getText() + " is an invalid poky directory.");
>> + setErrorMessage("Directory " + projectPath + " is an invalid poky
>> directory.");
>> return false;
>> }
>> }
>>
>> try {
>> - URI location = new URI("file://" +
>> txtProjectLocation.getText()+File.separator+txtProjectName.getText());
>> + URI location = new URI("file://" + projectPath);
>> IStatus status =
>> ResourcesPlugin.getWorkspace().validateProjectLocationURI(proj,
>> location);
>> if (!status.isOK()) {
>> setErrorMessage(status.getMessage());
>> --
>> 2.4.11
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>>
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-19 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-18 20:29 [eclipse-poky][PATCH v2] OptionsPage.java: improved handling of path concatenation in new project Humberto Ibarra
2016-05-19 16:32 ` timothy.t.orling
2016-05-19 17:32 ` timothy.t.orling
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.