* [PATCH net-next] qdisc: basic classifier - remove unnecessary initialization
@ 2013-09-27 0:42 Stephen Hemminger
2013-09-29 11:28 ` Jamal Hadi Salim
2013-09-30 19:48 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2013-09-27 0:42 UTC (permalink / raw)
To: Jamal Hadi Salim, David Miller; +Cc: netdev
err is set once, then first code resets it.
err = tcf_exts_validate(...)
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/net/sched/cls_basic.c 2013-08-10 10:36:11.657498301 -0700
+++ b/net/sched/cls_basic.c 2013-09-05 18:05:14.718200833 -0700
@@ -137,7 +137,7 @@ static int basic_set_parms(struct net *n
struct nlattr **tb,
struct nlattr *est)
{
- int err = -EINVAL;
+ int err;
struct tcf_exts e;
struct tcf_ematch_tree t;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] qdisc: basic classifier - remove unnecessary initialization
2013-09-27 0:42 [PATCH net-next] qdisc: basic classifier - remove unnecessary initialization Stephen Hemminger
@ 2013-09-29 11:28 ` Jamal Hadi Salim
2013-09-30 19:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2013-09-29 11:28 UTC (permalink / raw)
To: Stephen Hemminger, David Miller; +Cc: netdev
On 13-09-26 08:42 PM, Stephen Hemminger wrote:
> err is set once, then first code resets it.
> err = tcf_exts_validate(...)
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
>
> --- a/net/sched/cls_basic.c 2013-08-10 10:36:11.657498301 -0700
> +++ b/net/sched/cls_basic.c 2013-09-05 18:05:14.718200833 -0700
> @@ -137,7 +137,7 @@ static int basic_set_parms(struct net *n
> struct nlattr **tb,
> struct nlattr *est)
> {
> - int err = -EINVAL;
> + int err;
> struct tcf_exts e;
> struct tcf_ematch_tree t;
>
Acked-by: Jamal Hadi Salim <hadi@mojatatu.com>
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] qdisc: basic classifier - remove unnecessary initialization
2013-09-27 0:42 [PATCH net-next] qdisc: basic classifier - remove unnecessary initialization Stephen Hemminger
2013-09-29 11:28 ` Jamal Hadi Salim
@ 2013-09-30 19:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-09-30 19:48 UTC (permalink / raw)
To: stephen; +Cc: jhs, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 26 Sep 2013 17:42:16 -0700
> err is set once, then first code resets it.
> err = tcf_exts_validate(...)
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-30 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 0:42 [PATCH net-next] qdisc: basic classifier - remove unnecessary initialization Stephen Hemminger
2013-09-29 11:28 ` Jamal Hadi Salim
2013-09-30 19:48 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.