* [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
@ 2013-09-21 20:26 ` Ján Veselý
0 siblings, 0 replies; 8+ messages in thread
From: Ján Veselý @ 2013-09-21 20:26 UTC (permalink / raw)
To: QEMU, QEMU
Device communication errors need to be reported to driver.
Add a debug message while at it.
Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
---
hw/usb/hcd-ohci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 35f0878..0396e33 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
struct ohci_ed *ed)
switch (ret) {
case USB_RET_IOERROR:
case USB_RET_NODEV:
+ DPRINTF("usb-ohci: got DEV ERROR\n");
OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
+ break;
case USB_RET_NAK:
DPRINTF("usb-ohci: got NAK\n");
return 1;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
@ 2013-09-21 20:26 ` Ján Veselý
0 siblings, 0 replies; 8+ messages in thread
From: Ján Veselý @ 2013-09-21 20:26 UTC (permalink / raw)
To: QEMU, QEMU
Device communication errors need to be reported to driver.
Add a debug message while at it.
Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
---
hw/usb/hcd-ohci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 35f0878..0396e33 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
struct ohci_ed *ed)
switch (ret) {
case USB_RET_IOERROR:
case USB_RET_NODEV:
+ DPRINTF("usb-ohci: got DEV ERROR\n");
OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
+ break;
case USB_RET_NAK:
DPRINTF("usb-ohci: got NAK\n");
return 1;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
2013-09-21 20:26 ` [Qemu-devel] " Ján Veselý
@ 2013-09-29 20:15 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2013-09-29 20:15 UTC (permalink / raw)
To: Ján Veselý; +Cc: QEMU, QEMU, Gerd Hoffmann
22.09.2013 00:26, Ján Veselý wrote:
> Device communication errors need to be reported to driver.
> Add a debug message while at it.
>
> Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
> ---
> hw/usb/hcd-ohci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
> index 35f0878..0396e33 100644
> --- a/hw/usb/hcd-ohci.c
> +++ b/hw/usb/hcd-ohci.c
> @@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
> struct ohci_ed *ed)
> switch (ret) {
> case USB_RET_IOERROR:
> case USB_RET_NODEV:
> + DPRINTF("usb-ohci: got DEV ERROR\n");
why is this "DEV ERROR" ? Note it is about 2 case statements, not one.
> OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
> + break;
> case USB_RET_NAK:
> DPRINTF("usb-ohci: got NAK\n");
> return 1;
While the actual interesting change (adding break) looks
correct, and the whole thing is trivial indeed, this area
has a maintainer, -- Cc'ing Gerd for this. If he's okay
I'll pick it up.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
@ 2013-09-29 20:15 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2013-09-29 20:15 UTC (permalink / raw)
To: Ján Veselý; +Cc: QEMU, QEMU, Gerd Hoffmann
22.09.2013 00:26, Ján Veselý wrote:
> Device communication errors need to be reported to driver.
> Add a debug message while at it.
>
> Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
> ---
> hw/usb/hcd-ohci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
> index 35f0878..0396e33 100644
> --- a/hw/usb/hcd-ohci.c
> +++ b/hw/usb/hcd-ohci.c
> @@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
> struct ohci_ed *ed)
> switch (ret) {
> case USB_RET_IOERROR:
> case USB_RET_NODEV:
> + DPRINTF("usb-ohci: got DEV ERROR\n");
why is this "DEV ERROR" ? Note it is about 2 case statements, not one.
> OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
> + break;
> case USB_RET_NAK:
> DPRINTF("usb-ohci: got NAK\n");
> return 1;
While the actual interesting change (adding break) looks
correct, and the whole thing is trivial indeed, this area
has a maintainer, -- Cc'ing Gerd for this. If he's okay
I'll pick it up.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
2013-09-29 20:15 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-30 6:32 ` Gerd Hoffmann
-1 siblings, 0 replies; 8+ messages in thread
From: Gerd Hoffmann @ 2013-09-30 6:32 UTC (permalink / raw)
To: Michael Tokarev; +Cc: Ján Veselý, QEMU, QEMU
Hi,
> While the actual interesting change (adding break) looks
> correct, and the whole thing is trivial indeed, this area
> has a maintainer, -- Cc'ing Gerd for this. If he's okay
> I'll pick it up.
Patch is fine.
Acked-by: Gerd Hoffmann <kraxel@gmail.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
@ 2013-09-30 6:32 ` Gerd Hoffmann
0 siblings, 0 replies; 8+ messages in thread
From: Gerd Hoffmann @ 2013-09-30 6:32 UTC (permalink / raw)
To: Michael Tokarev; +Cc: Ján Veselý, QEMU, QEMU
Hi,
> While the actual interesting change (adding break) looks
> correct, and the whole thing is trivial indeed, this area
> has a maintainer, -- Cc'ing Gerd for this. If he's okay
> I'll pick it up.
Patch is fine.
Acked-by: Gerd Hoffmann <kraxel@gmail.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
2013-09-30 6:32 ` [Qemu-devel] " Gerd Hoffmann
@ 2013-09-30 7:58 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2013-09-30 7:58 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Ján Veselý, QEMU, QEMU
30.09.2013 10:32, Gerd Hoffmann wrote:
> Hi,
>
>> While the actual interesting change (adding break) looks
>> correct, and the whole thing is trivial indeed, this area
>> has a maintainer, -- Cc'ing Gerd for this. If he's okay
>> I'll pick it up.
>
> Patch is fine.
No, I didn't ask whenever the patch is fine, I wanted to
ensure you wont blame me for accepting a trivial patch
for an area which has an active maintainer... ;)
Thanks, queued up for trivial-patches!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
@ 2013-09-30 7:58 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2013-09-30 7:58 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Ján Veselý, QEMU, QEMU
30.09.2013 10:32, Gerd Hoffmann wrote:
> Hi,
>
>> While the actual interesting change (adding break) looks
>> correct, and the whole thing is trivial indeed, this area
>> has a maintainer, -- Cc'ing Gerd for this. If he's okay
>> I'll pick it up.
>
> Patch is fine.
No, I didn't ask whenever the patch is fine, I wanted to
ensure you wont blame me for accepting a trivial patch
for an area which has an active maintainer... ;)
Thanks, queued up for trivial-patches!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-09-30 7:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-21 20:26 [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td Ján Veselý
2013-09-21 20:26 ` [Qemu-devel] " Ján Veselý
2013-09-29 20:15 ` [Qemu-trivial] " Michael Tokarev
2013-09-29 20:15 ` [Qemu-devel] " Michael Tokarev
2013-09-30 6:32 ` Gerd Hoffmann
2013-09-30 6:32 ` [Qemu-devel] " Gerd Hoffmann
2013-09-30 7:58 ` Michael Tokarev
2013-09-30 7:58 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.