From: gerg@uclinux.org (Greg Ungerer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ks8695: fix incorrect placement of __initdata tag
Date: Tue, 01 Oct 2013 08:43:40 +1000 [thread overview]
Message-ID: <5249FE9C.2000208@uclinux.org> (raw)
In-Reply-To: <1551134.v305P4LSfh@amdc1032>
On 30/09/13 23:02, Bartlomiej Zolnierkiewicz wrote:
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
> ---
> arch/arm/mach-ks8695/board-og.c | 2 +-
> arch/arm/mach-ks8695/cpu.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-ks8695/board-og.c b/arch/arm/mach-ks8695/board-og.c
> index 002bc61..9204f5a 100644
> --- a/arch/arm/mach-ks8695/board-og.c
> +++ b/arch/arm/mach-ks8695/board-og.c
> @@ -79,7 +79,7 @@ static void __init og_pci_bus_reset(void)
> #define S8250_VIRT 0xf4000000
> #define S8250_SIZE 0x00100000
>
> -static struct __initdata map_desc og_io_desc[] = {
> +static struct map_desc og_io_desc[] __initdata = {
> {
> .virtual = S8250_VIRT,
> .pfn = __phys_to_pfn(S8250_PHYS),
> diff --git a/arch/arm/mach-ks8695/cpu.c b/arch/arm/mach-ks8695/cpu.c
> index ddb2422..9618654 100644
> --- a/arch/arm/mach-ks8695/cpu.c
> +++ b/arch/arm/mach-ks8695/cpu.c
> @@ -33,8 +33,7 @@
> #include <mach/regs-sys.h>
> #include <mach/regs-misc.h>
>
> -
> -static struct __initdata map_desc ks8695_io_desc[] = {
> +static struct map_desc ks8695_io_desc[] __initdata = {
> {
> .virtual = (unsigned long)KS8695_IO_VA,
> .pfn = __phys_to_pfn(KS8695_IO_PA),
>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gerg@uclinux.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] ARM: ks8695: fix incorrect placement of __initdata tag
Date: Tue, 01 Oct 2013 08:43:40 +1000 [thread overview]
Message-ID: <5249FE9C.2000208@uclinux.org> (raw)
In-Reply-To: <1551134.v305P4LSfh@amdc1032>
On 30/09/13 23:02, Bartlomiej Zolnierkiewicz wrote:
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
> ---
> arch/arm/mach-ks8695/board-og.c | 2 +-
> arch/arm/mach-ks8695/cpu.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-ks8695/board-og.c b/arch/arm/mach-ks8695/board-og.c
> index 002bc61..9204f5a 100644
> --- a/arch/arm/mach-ks8695/board-og.c
> +++ b/arch/arm/mach-ks8695/board-og.c
> @@ -79,7 +79,7 @@ static void __init og_pci_bus_reset(void)
> #define S8250_VIRT 0xf4000000
> #define S8250_SIZE 0x00100000
>
> -static struct __initdata map_desc og_io_desc[] = {
> +static struct map_desc og_io_desc[] __initdata = {
> {
> .virtual = S8250_VIRT,
> .pfn = __phys_to_pfn(S8250_PHYS),
> diff --git a/arch/arm/mach-ks8695/cpu.c b/arch/arm/mach-ks8695/cpu.c
> index ddb2422..9618654 100644
> --- a/arch/arm/mach-ks8695/cpu.c
> +++ b/arch/arm/mach-ks8695/cpu.c
> @@ -33,8 +33,7 @@
> #include <mach/regs-sys.h>
> #include <mach/regs-misc.h>
>
> -
> -static struct __initdata map_desc ks8695_io_desc[] = {
> +static struct map_desc ks8695_io_desc[] __initdata = {
> {
> .virtual = (unsigned long)KS8695_IO_VA,
> .pfn = __phys_to_pfn(KS8695_IO_PA),
>
next prev parent reply other threads:[~2013-09-30 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 13:02 [PATCH] ARM: ks8695: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-09-30 13:02 ` Bartlomiej Zolnierkiewicz
2013-09-30 22:43 ` Greg Ungerer [this message]
2013-09-30 22:43 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5249FE9C.2000208@uclinux.org \
--to=gerg@uclinux.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.